Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

935-Admin auth with google #1005

Merged
merged 1 commit into from
Feb 4, 2025
Merged

935-Admin auth with google #1005

merged 1 commit into from
Feb 4, 2025

Conversation

NVMakarenko
Copy link
Contributor

dev

Project

Code reviewers

Summary of issue

Admin chould sign in via Google auth.

Summary of change

add credentials and config devise.rb

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • PR meets all conventions

@NVMakarenko NVMakarenko self-assigned this Dec 9, 2024
@NVMakarenko NVMakarenko changed the title add creds into devise 935-Admin auth with google Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (bbb06b3) to head (9fb1aa1).
Report is 37 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1005   +/-   ##
========================================
  Coverage    91.82%   91.82%           
========================================
  Files           74       74           
  Lines         1052     1052           
========================================
  Hits           966      966           
  Misses          86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NVMakarenko NVMakarenko linked an issue Dec 9, 2024 that may be closed by this pull request
@NVMakarenko NVMakarenko requested a review from loqimean December 9, 2024 09:17
@loqimean loqimean merged commit 2e994f7 into develop Feb 4, 2025
5 checks passed
@loqimean loqimean deleted the 935-add-env-cred branch February 4, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for QA
Development

Successfully merging this pull request may close these issues.

[Sign in] via Google account.
2 participants