Upload the calculator logo #982
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #982 +/- ##
===========================================================
+ Coverage 89.64% 89.71% +0.06%
===========================================================
Files 69 69
Lines 1111 1118 +7
===========================================================
+ Hits 996 1003 +7
Misses 115 115 ☔ View full report in Codecov by Sentry. |
KseniaGovorun
force-pushed
the
970-ability-upload-logo
branch
from
e4b6ed9 to
4f47f52
Compare
NVMakarenko
approved these changes
Dec 11, 2024
olexandervanzuriak
force-pushed
the
970-ability-upload-logo
branch
from
fd63145 to
e3a6762
Compare
…cts/ZeroWaste into 970-ability-upload-logo
…cts/ZeroWaste into 970-ability-upload-logo
loqimean
requested changes
Jan 20, 2025
| @@ -0,0 +1,5 @@ | |||
| <% if @calculator.logo_picture.attached? %> | |||
| <%= image_tag(@calculator.logo_picture.variant(resize_to_fill: [428, 307])) %> | |||
There was a problem hiding this comment.
use constant for this dimension definition
app/views/calculators/show.html.erb
Outdated
Comment on lines
28
to
33
| <% if @calculator.logo_picture.attached? %> | ||
| <%= image_tag @calculator.logo_picture, class: "constructor-calculator-scales", alt: t(".image_alt") %> | ||
| <% else %> | ||
| <%# Default image %> | ||
| <%= image_tag "scales.png", class: "constructor-calculator-scales", alt: t(".image_alt") %> | ||
| <% end %> |
There was a problem hiding this comment.
move logic to get default, or attached image to model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
Code reviewers
Summary of issue
The user should be able to upload the calculator logo
Summary of change
CHECK LIST
Show page
Calculator_image.mp4