Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor game to React Hooks #19

Open
itaditya opened this issue Sep 30, 2019 · 3 comments
Open

Refactor game to React Hooks #19

itaditya opened this issue Sep 30, 2019 · 3 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@itaditya
Copy link
Owner

  1. Convert Game.js to functional component.
  2. Use common React hooks like useState, useRef, useEffect.
  3. Make sure existing tests pass without any change in test files.
@itaditya itaditya added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Sep 30, 2019
@pavelkeyzik
Copy link

I can do this

@itaditya
Copy link
Owner Author

itaditya commented Oct 5, 2019

@pavelkeyzik my bad on opening this issue so early. I appreciate the hard work you have done and also the extra work done to refactor the new code introduced by PRs getting merged daily.

The reason I didn't merge it till now was that I wanted beginners to also contribute to the project. Once we add hooks to the code the learning curve will increase and so many beginners might be discouraged to work on the project.

Here's what I'll do, once the momentum of this project goes down, I'll comment here and give you the green flag. Then you can update the code once and I'll make sure I don't merge any other code before yours. I'll ensure your PR gets merged before Hacktoberfest is over. Cheers!

@pavelkeyzik
Copy link

@itaditya Okay! Sounds great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants