Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed class component to functional inside Game.js file #20

Conversation

pavelkeyzik
Copy link

@pavelkeyzik pavelkeyzik commented Sep 30, 2019

HI! Now your file Game.js uses React Hooks ( #19 ). Also, I upgraded React and React DOM version to be able to work with React Hooks. Can you check my work?

Thanks a lot for Hacktoberfest label.

src/Game.js Outdated Show resolved Hide resolved
@pavelkeyzik pavelkeyzik force-pushed the feauture/mirgating-to-react-hooks branch from 81c7852 to 35fb7cf Compare October 2, 2019 06:14
src/Game.js Outdated Show resolved Hide resolved
src/Game.js Outdated Show resolved Hide resolved
@pavelkeyzik
Copy link
Author

We have several PRs that change the src/Game.js file. All merged PRs make conflicts with my PR. Maybe we need to wait until all PRs will be merged and then I will fix conflicts? Or will it be better to merge the version with hooks and let people write their code with hooks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants