resolution of Django template for the example sp #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
reviewed
Nov 13, 2023
| @@ -0,0 +1,40 @@ | |||
| {% extends "base.html" %} | |||
|
|
|||
| {%block tab_active%} active{%endblock%} | |||
There was a problem hiding this comment.
Suggested change
| {%block tab_active%} active{%endblock%} | |
| {% block tab_active %} active{% endblock %} |
peppelinux
requested changes
Nov 13, 2023
| <div class="container"> | ||
| <div class="row"> | ||
| <div class="col-lg-6 offset-lg-1 order-lg-2"> | ||
| <img src="https://picsum.photos/800/600" title="titolo immagine" alt="descrizione immagine" class="img-fluid"> |
There was a problem hiding this comment.
please change the following value with a static image on the local storage, using {% static "..." %}
"https://picsum.photos/800/600"
| <div class="card-body pb-5"> | ||
| <div class="category-top"> | ||
| <svg class="icon"> | ||
| <use xlink:href="/bootstrap-italia/dist/svg/sprites.svg#it-calendar"></use> |
There was a problem hiding this comment.
Suggested change
| <use xlink:href="/bootstrap-italia/dist/svg/sprites.svg#it-calendar"></use> | |
| <use xlink:href="/bootstrap-italia/dist/svg/sprites.svg#it-calendar"></use> |
please use {% static %}, don't use absolute webpaths
There was a problem hiding this comment.
here and in all the occurences
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is relative to the issue #136
We are adding a first mock up of the Service Provider page.