Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satosa-Saml2Spid/Eudi - Readme Review for initial setup of the environment #95

Merged
merged 7 commits into from
Dec 2, 2023

Conversation

davidelongo-ey
Copy link
Contributor

modified files:

  1. eudi/README.md (add new section [How to start the environment])
  1. eudi/README-Setup.md
  2. eudi/example_sp/djangosaml2_sp/README.md

README-Setup.md Outdated Show resolved Hide resolved
README-Setup.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved



if everithings is ok, go to the path `/{your path}/Satosa-Saml2Spid/example_sp` and execute the following commands
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only for the DEMO

it doesn't bring any value for a production environment

please distinguish a general setup for a demo setup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved in the section above, related to the DEMO SAML2 SP

README.md Outdated


Satosa-Saml2Spid image is built with production ready logic.
The docker compose may use the [enviroment variables](#configuration-by-environment-variables)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have tested the docker compose ENV variables?
They doesn't seem to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean the "Anchor" doesn't work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the Docker Compose ENVIRONMENT Variables

README-Setup.md Outdated Show resolved Hide resolved
README-Setup.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

## Setup
#### STEP 3 - Install and Run Djangosaml2 demo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### STEP 3 - Install and Run Djangosaml2 demo
#### STEP 3 - Install and Run a Demo SAML2 Service Provider

@peppelinux peppelinux merged commit d10df79 into italia:eudi Dec 2, 2023
2 checks passed
peppelinux pushed a commit that referenced this pull request Jan 24, 2024
* pyeudiw conf

* fix: discovery page and entity configuration endpoint

* fix: openid4vp backend base_url

* feat: qrcode templates

* chore: openid4vp backend example conf

* feat: added mongodb in pyeudiw backend conf

* feat: aligne pyeudiw backend conf

* chore: alignment of openid4vp backend example with pyeudiw dev branch

* chore: pyeudiw backend example update

* aligned pyeudiw backend assets

* fix: pyeudiw v0.5.0 alignments

* uwsgi setup nginx and spid idps js

* chore: uwsgi examples init scripts and nginx improvements

* feat: nginx hardening

* eudi small alignments

* uwsgi not truncating long debug messages

* Docker revamping (#90)

* python version selected dinamically for docker version

* fixed python version

* added enviroments description

* fix enviroment's name and echo

* fir doker-compose and readme files

* fix: change library from libressl-dev to openssl-dev

* Update target_based_routing.yaml

Fixed ficep entity_id name

* New ficep metadata

* chore: added dependency for django theme

* Fix: remove of non existing field of user

* feat: implemented Django template for the example sp

* chore: example project - disco, proxy_conf and README

* chore: README

* chore: README added CORSO IDEM Proxy

* fix: Docker compose

* fix: Docker compose - README

* fix: Docker compose - README

* pyff folder renamed

* Docker revamp

* Docker revamp

* chore: created static folder with static files

* fix: adding missing STATIC_ROOT

* fix: using {% static %} for static resources

* fix: removed unused code

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Docker revamp

* fix: Docker entrypoint

* chore: README

* chore: README

* fix: docker compose

---------

Co-authored-by: Alessio Murru <alessio.murru@it.ey.com>
Co-authored-by: MDreW <andrea.ranaldi@gmail.com>
Co-authored-by: Gartic99 <artic.1804049@studenti.uniroma1.it>
Co-authored-by: Ghenadie Artic <57416779+Gartic99@users.noreply.github.com>

* fix: compose and and idp button

* fix: spid backend target routing

* chore: spid-saml-check animated gif

* fix: general configuration and documentation

* Feat: by clicking on my name, you have a dropdown (#93)

* chore: added dependency for django theme

* Fix: remove of non existing field of user

* feat: implemented Django template for the example sp

* chore: created static folder with static files

* fix: adding missing STATIC_ROOT

* fix: using {% static %} for static resources

* fix: removed unused code

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* feat: dropdown for profile

* fix: resolved merge conflicts

---------

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Merged PR #81 into EUDI (#94)

* new discovery and error page based on bootstrap-itali v2.6.1

* added id and class for errors

* chore: added dependency for django theme

* Fix: remove of non existing field of user

* feat: implemented Django template for the example sp

* chore: created static folder with static files

* fix: adding missing STATIC_ROOT

* fix: using {% static %} for static resources

* fix: removed unused code

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* feat: dropdown for profile

* fix: resolved merge conflicts

* chore: removed comments on disco.html file

* feat: improved echo_attributes page

* Update Docker-compose/docker-compose.yml

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

---------

Co-authored-by: MDreW <andrea.ranaldi@gmail.com>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Satosa-Saml2Spid/Eudi - Readme Review for initial setup of the environment (#95)

* Modifica Readme Satosa-Saml2Spid

* aggiornamento django Readme

* aggiornamento  Readme

* Update readme - second release

* update - review readme

* create new Readme about DEMO SAML2 SP + remove blanck lines + modified django readme

* Apply suggestions from code review

---------

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* ci: only py3.10 since it will be tested using docker

* fix: djangosaml2 example sp templates and conf

* chore: README wallet demo

* chore: updated discovery page image

* chore: updated discovery page image

* chore: README editorials

* fix: wallet demo animated gif dimensions

* fix: wallet demo animated gif dimensions

* fix: sumamry

* update CI workflow (Revision 1) (#96)

* update CI workflow (Revision 1)

* remove pip install line 35

* Update CI workflow -  revision 2

* ADD django_sp in Docker-compose and revisited CI workflow (#97)

* Update CI workflow + ADD django_sp in Docker-compose

* Update CI Workflow - Review 2

* Update CI Workflow - Review 2.1

* Update CI Workflow - Review 2.2

* Update CI workflow + Docker-compose (review 3.1)

* feat: qrcode loaded by client (#98)

* new discovery and error page based on bootstrap-itali v2.6.1

* added id and class for errors

* chore: added dependency for django theme

* Fix: remove of non existing field of user

* feat: implemented Django template for the example sp

* chore: created static folder with static files

* fix: adding missing STATIC_ROOT

* fix: using {% static %} for static resources

* fix: removed unused code

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* feat: dropdown for profile

* fix: resolved merge conflicts

* chore: removed comments on disco.html file

* feat: improved echo_attributes page

* feat: qrcode loaded by js library

* fix: qrcode_color set by parameter

---------

Co-authored-by: MDreW <andrea.ranaldi@gmail.com>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Remove `apply_conf.sh` script (#103)

* fix: remove `apply_conf.sh` script and use ENV vars instead

* fix: remove `apply_conf.sh` script and use ENV vars instead

* fix: delete `apply_conf.sh` file

* fix: separate `SATOSA_BASE_STATIC` from `SATOSA_BASE`

---------

Co-authored-by: Salvatore Laiso <salvatore.laiso@it.ey.com>

* Add in "External references" readme section the reference of pyeudiw doc (#104)

* Update CI workflow + ADD django_sp in Docker-compose

* Update CI Workflow - Review 2

* Update CI Workflow - Review 2.1

* Update CI Workflow - Review 2.2

* Update CI workflow + Docker-compose (review 3.1)

* issue #92 - add pyeudiw documentation ref

* issue #92 - add pyeudiw documentation ref (review)

* issue #92 - add pyeudiw documentation ref (review2)

* Fixes pre release 0.8.0 (#105)

* fix: align pyeudiw yaml config file

* fix: align disco page to pyeudiw

* fix: align base html to pyeudiw

* fix: align qrcode to pyeudiw

* fix: change reference to correct bootstrap

* fix: add statics needed by spid_base

* doc: update Configuration by environment variables section

* Fix CI pre-release (#107)

* fix: github action

* fix: temporary retrieve `pyeudiw` from github repo

* fix: add `eudi` branch into CI triggers

* chore: linting and container status info

* fix: missing dependencies in CI host machine

* fix: wait container startup

* fix: add healthcheck

---------

Co-authored-by: Salvatore Laiso <salvatore.laiso@it.ey.com>

---------

Co-authored-by: root <root@it-wallet-tmp.mpokl4s14jhunpbwqmmurqxrkb.fx.internal.cloudapp.net>
Co-authored-by: Alessio Murru <alessio.murru@it.ey.com>
Co-authored-by: MDreW <andrea.ranaldi@gmail.com>
Co-authored-by: Gartic99 <artic.1804049@studenti.uniroma1.it>
Co-authored-by: Ghenadie Artic <57416779+Gartic99@users.noreply.github.com>
Co-authored-by: Davide Longo <139359776+davidelongo-ey@users.noreply.github.com>
Co-authored-by: Salvatore Laiso <32564922+salvatorelaiso@users.noreply.github.com>
Co-authored-by: Salvatore Laiso <salvatore.laiso@it.ey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants