feat: improve validation and UI/UX #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes are somewhat interconnected by I can split them up if the single commit is a problem. |
* fix: centered layout in home page * fix: don't mention E.164 in phone number validation E.164 is unknown to most users. Besides, the validation never checked for it anyway and the majority of past onboardings were performed with no international prefix. * feat: accept spaces in phone numbers to lower the chance for error and improve the UX. * feat: better PA picker (Fixes italia#158) The PA picker in home page does not flicker when typing, provides loading feedback, it's properly aligned and doesn't rely on the readonly support fields anymore. The result are shown in a more intuitive way. Also, the input is debounced and makes less calls to Elasticsearch. * fix: ability to edit the form on error (Fixes italia#159) When the server side validation fails, the user can now fix what's wrong right there instead of starting over. * refactor: simplify the validators (Fixes italia#138) * feat: code hosting URL validation The validation now rejects non HTTPS URLs and URLs that don't look like a code hosting organization. (ie. https://github.com/foobar/repo will be rejected, but https://github.com/foobar won't)
libremente
reviewed
Oct 27, 2021
| * @param {string} ipa | ||
| * @param {string} url | ||
| */ | ||
| function checkDups(ipa, url) { | ||
| function isAlreadyOnboarded(ipa, url) { |
There was a problem hiding this comment.
@libremente the regex should already be checking for an organization, making it impossible to add a single repo
There was a problem hiding this comment.
That regex is fine, however we still have the org vs user issue, since that checks only the form of the URL and not the substance, right?
There was a problem hiding this comment.
@libremente That's correct but for us to tell those two cases apart we have to use the code hostings' APIs (ie, we can address that in a separate patch).
sebbalex
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: centered layout in home page
fix: don't mention E.164 in phone number validation
E.164 is unknown to most users.
Besides, the validation never checked for it anyway and the
majority of past onboardings were performed with no international
prefix.
feat: accept spaces in phone numbers to lower the chance for
error and improve the UX.
feat: better PA picker (Fixes Rethink the PA picker widget #158)
The PA picker in home page does not flicker when typing,
it's properly aligned and doesn't rely on the readonly support
fields anymore.
The results are shown in a more intuitive way.
Also, the input is debounced and makes less calls to Elasticsearch.
fix: ability to edit the form on error (Fixes Can't continue the compilation on error #159)
When the server side validation fails, the user can now fix what's
wrong right there instead of starting over.
refactor: simplify the validators (Fixes Refactor the validation logic #138)
feat: code hosting URL validation
The validation now rejects non HTTPS URLs and URLs that don't
look like a code hosting organization.
(ie. https://github.com/foobar/repo will be rejected, but
https://github.com/foobar won't)