Tabline disappears in vim-lsp popup #422
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Google translation)
vim-lsp has lightline temporarily disable processing Included,
As a result, the content of [tabline] was lost.
After temporarily disabling, when enable it obtained by
lightline # init
Set
s: _tabline
to& tabline
, butIf
& tabline
is changed afterlightline # init
, it will not be restored.(Such as when another plugin makes a change)
Should
& tabline
not be changed whens: lightline.enable.tabline
is disabled,If
& tabline
ands: _tabline
are different at the timing oflightline # disable
, whether to sets: _tabline
again,I was worried about which solution was better, but I chose the one with less correction.
Please review.
vim-lspにはlightlineを一時的に無効にする処理が含まれていますが、
この影響で、[tabline]の内容が消えてしまう現象がありました。
一時的に無効にした後、有効にする際に
lightline#init
で取得したs:_tabline
を&tabline
に設定しますが、lightline#init
後に&tabline
が変更されていた場合に元通りの設定になりません。(他のプラグインが変更を行った場合など)
s:lightline.enable.tabline
が無効の場合に&tabline
には変更を行わないようにするべきか、lightline#disable
のタイミングで&tabline
とs:_tabline
が異なっていれば再度s:_tabline
を設定し直すべきか、どちらの対応が良いのか悩みましたが、修正量の少ない方を選んでみました。
レビューお願いします。
(日本語ですみません。。。)