Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabline disappears in vim-lsp popup #422

Closed
wants to merge 1 commit into from
Closed

Tabline disappears in vim-lsp popup #422

wants to merge 1 commit into from

Conversation

sabiz
Copy link

@sabiz sabiz commented Feb 17, 2020

(Google translation)
vim-lsp has lightline temporarily disable processing Included,
As a result, the content of [tabline] was lost.

After temporarily disabling, when enable it obtained by lightline # init
Set s: _tabline to & tabline, but
If & tabline is changed after lightline # init, it will not be restored.
(Such as when another plugin makes a change)

Should & tabline not be changed when s: lightline.enable.tabline is disabled,
If & tabline and s: _tabline are different at the timing of lightline # disable, whether to set s: _tabline again,
I was worried about which solution was better, but I chose the one with less correction.
Please review.


vim-lspにはlightlineを一時的に無効にする処理が含まれていますが、
この影響で、[tabline]の内容が消えてしまう現象がありました。

一時的に無効にした後、有効にする際にlightline#initで取得した
s:_tabline&tablineに設定しますが、
lightline#init後に&tablineが変更されていた場合に元通りの設定になりません。
(他のプラグインが変更を行った場合など)

s:lightline.enable.tablineが無効の場合に&tablineには変更を行わないようにするべきか、
lightline#disableのタイミングで&tablines:_tablineが異なっていれば再度s:_tablineを設定し直すべきか、
どちらの対応が良いのか悩みましたが、修正量の少ない方を選んでみました。
レビューお願いします。

(日本語ですみません。。。)

@itchyny
Copy link
Owner

itchyny commented Feb 17, 2020

First of all, those lines of vim-lsp should be removed as prabirshrestha/vim-lsp#677 proposes. Does this fix solve the problem?

@sabiz
Copy link
Author

sabiz commented Feb 17, 2020

I think will solve this.
However, it reproduces that there are times when lightline#enable is performed after startup.

It is unlikely that the user will do call lightline#enable() himself,
prabirshrestha/vim-lsp#677 I think it's fine to solve it.


vim-lspにおいては解決すると思います。
しかし、lightline#enableを起動後行うことがあると再現します。

ユーザー自らcall lightline#enable()を行うケースはなさそうなので、
prabirshrestha/vim-lsp#677 で解決ということでも良いと思います。

@itchyny
Copy link
Owner

itchyny commented Feb 19, 2020

Since prabirshrestha/vim-lsp#677 is merged, I close this issue. Please reopen if you still find the problem.

@itchyny itchyny closed this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants