Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set max_limit to 100 for joblistings #59

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Set max_limit to 100 for joblistings #59

merged 2 commits into from
Sep 25, 2019

Conversation

odinuge
Copy link
Member

@odinuge odinuge commented Sep 25, 2019

No description provided.

@odinuge odinuge mentioned this pull request Sep 25, 2019
Merged
@SmithPeder
Copy link
Member

SmithPeder commented Sep 25, 2019 •
edited
Loading

How does this work with regards to the frontend 18 number? Will there not be fetched more then 100 total joblistings?

@odinuge
Copy link
Member Author

odinuge commented Sep 25, 2019

This is just the max_size, so all sizes below and equal are legal

@SmithPeder
Copy link
Member

So the max_size per fetch, or the total max size?

@odinuge
Copy link
Member Author

odinuge commented Sep 25, 2019

Max size per query, so first: 100 would now be legal.

@SmithPeder SmithPeder merged commit 888a14f into master Sep 25, 2019
@aleksandervestlund aleksandervestlund deleted the inc-pagination-joblistings branch February 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmithPeder SmithPeder SmithPeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odinuge @SmithPeder