Possible fix for failsound/applause not stopping #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me too. Thanks! |
itdelatrisu
added a commit
that referenced
this pull request
Jun 1, 2017
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hi again, I've put up a possible fix for #276 (translations would have to wait until I get the new options overlay merged)
Notes
The way it works rely on how
getClip()works on the MultiClip class. On my setup, this solves the problem.It doesn't mute the clip but instead stops it so it can be played again, although not completely sure if this will work in other setups...