Handle forward references in a forward-compatible way #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrbel
reviewed
Jul 23, 2019
apistrap/utils.py
Outdated
| return eval(annotation, globs) | ||
|
|
||
|
|
||
| def get_type_hints(function): |
There was a problem hiding this comment.
missing param/return typehints & brief doc
apistrap/utils.py
Outdated
| return globs | ||
|
|
||
|
|
||
| def resolve_fw_decl(function, annotation, globs=None, level=0, search_stack_depth=2): |
There was a problem hiding this comment.
missing param/return typehints & brief doc
maybe rename to _resolve_fw_decl?
apistrap/utils.py
Outdated
| @@ -34,3 +36,33 @@ def snake_to_camel(value): | |||
| """ | |||
| result = "".join(x.capitalize() or "_" for x in value.split("_")) | |||
| return result[0].lower() + result[1:] | |||
|
|
|||
|
|
|||
| def get_function_perspective_globals(function, level=0, max_level=None): | |||
There was a problem hiding this comment.
missing param/return typehints & brief doc
maybe rename to _get_function_perspective_globals and leave without docs
| return wrapper | ||
|
|
||
| def _check_request_type(self, *args, **kwargs): | ||
| if self._get_request_content_type(*args, **kwargs) != "application/json": | ||
| raise ApiClientError("Unsupported media type, JSON is expected") | ||
|
|
||
| def _process_request_kwargs(self, body, signature, request_arg, *args, **kwargs): | ||
| def _process_request_kwargs(self, body, signature, request_arg: str, *args, **kwargs): |
There was a problem hiding this comment.
missing typehints for body and signature.. or are the too complicated?
Merged
blazekadam
approved these changes
Aug 12, 2019
|
|
||
| globs = get_function_perspective_globals(function) | ||
|
|
||
| return eval(annotation, globs) |
|
we can ignore the coverage |
|
@blazekadam Well, once (if?) Python implements looking up type annotations in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.