Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextCloud/OwnCloud Append Connection Path to Default Path #15621

Closed
Tracked by #15874
AliveDevil opened this issue Feb 8, 2024 · 7 comments · Fixed by #15876 or #15911
Closed
Tracked by #15874

NextCloud/OwnCloud Append Connection Path to Default Path #15621

AliveDevil opened this issue Feb 8, 2024 · 7 comments · Fixed by #15876 or #15911
Assignees
Labels
enhancement nextcloud Nextcloud Server owncloud ownCloud Server
Milestone

Comments

@AliveDevil
Copy link
Contributor

AliveDevil commented Feb 8, 2024

When configuring a NextCloud/OwnCloud connection, users can easily get tripped by how the path is configured in these profiles.

With an empty path the Home feature is used, defaulting to remote.php/dav/files/username. When a path is set the Home feature isn't used, thus Cyberduck tries to mount /Path/To/Some/Folder, which should really be remote.php/dav/files/username/Path/To/some/Folder.

Proposal:
Unconditionally prepend "remote.php/dav/files/username" to all paths coming from a connection.
Additionally: Make prefix configurable - as in

<key>Properties</key>
<array>
    <string>connection.url.base=remote.php/dav/files/${username}</string>
</array>

Where Username-token is replaced in HostPreferences to host configured username.

@AliveDevil AliveDevil added enhancement nextcloud Nextcloud Server owncloud ownCloud Server labels Feb 8, 2024
@AliveDevil
Copy link
Contributor Author

Häufig ist da noch ein reverse proxy vorne dran, so dass der default pfad nicht mehr stimmt.

Quote @dkocher

Often there is a reverse proxy in front, changing the default path.

@dkocher
Copy link
Contributor

dkocher commented Apr 24, 2024

We could possibly improve this by reading the WebDAV root from the capabilities API as mentioned in #15860.

@dkocher
Copy link
Contributor

dkocher commented Apr 28, 2024

Unfortunately the OCS capabilities seem to return an invalid value

…
 <capabilities>
   <core>
    <pollinterval>60</pollinterval>
    <webdav-root>remote.php/webdav</webdav-root>
…

advertising remote.php/webdav instead of remote.php/dav.

dkocher added a commit that referenced this issue Apr 28, 2024
@dkocher dkocher linked a pull request Apr 28, 2024 that will close this issue
2 tasks
dkocher added a commit that referenced this issue Apr 28, 2024
dkocher added a commit that referenced this issue Apr 28, 2024
dkocher added a commit that referenced this issue Apr 28, 2024
@ylangisc
Copy link
Contributor

Unfortunately the OCS capabilities seem to return an invalid value

…
 <capabilities>
   <core>
    <pollinterval>60</pollinterval>
    <webdav-root>remote.php/webdav</webdav-root>
…

advertising remote.php/webdav instead of remote.php/dav.

Per the documentation the only non-legacy endpoint is dav/spaces/.

@dkocher
Copy link
Contributor

dkocher commented Apr 29, 2024

Per the documentation the only non-legacy endpoint is dav/spaces/.

We will only change that as part of much larger effort switching to Libre Graph API with #14166.

dkocher added a commit that referenced this issue Apr 30, 2024
@dkocher dkocher added this to the 8.9.0 milestone May 2, 2024
@dkocher dkocher self-assigned this May 2, 2024
@dkocher
Copy link
Contributor

dkocher commented May 3, 2024

I want to revisit this to make sure we support more configurations in bookmarks and deployments

  • Deployments with prefix to default Nextcloud URIs (example.net/nextcloud) or root (example.net/)
  • Bookmarks configured with custom path using /remote.php/webdav/path
  • Bookmarks configured with custom path using /remote.php/dav/username/path

@dkocher dkocher reopened this May 3, 2024
@dkocher
Copy link
Contributor

dkocher commented May 3, 2024

dkocher added a commit that referenced this issue May 6, 2024
@dkocher dkocher linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement nextcloud Nextcloud Server owncloud ownCloud Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants