Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15137 #15138

Merged
merged 4 commits into from
May 27, 2024
Merged

Fix #15137 #15138

merged 4 commits into from
May 27, 2024

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Sep 23, 2023 •
edited
Loading

macOS

image

Windows

image

@dkocher dkocher requested a review from a team as a code owner September 23, 2023 12:34
@dkocher dkocher added this to the 8.7.0 milestone Sep 23, 2023
@dkocher dkocher linked an issue Sep 23, 2023 that may be closed by this pull request
Provide preference to enable versioning of files edited in external application #15137
Closed
@dkocher dkocher marked this pull request as draft September 23, 2023 12:35
@dkocher dkocher force-pushed the feature/GH-15137 branch 5 times, most recently from c3d66dd to 5c15185 Compare September 25, 2023 15:18
@dkocher dkocher modified the milestones: 8.7.0, 9.0 Oct 6, 2023
@dkocher dkocher force-pushed the feature/GH-15137 branch from 3fe3ddc to 8c27878 Compare May 8, 2024 13:52
@dkocher dkocher modified the milestones: 9.0, 8.9.0 May 14, 2024
AliveDevil
AliveDevil requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@AliveDevil AliveDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Preferences.strings.1 for WinForms.

@dkocher dkocher marked this pull request as ready for review May 15, 2024 10:48
@dkocher dkocher requested review from AliveDevil and ylangisc May 15, 2024 10:48
@dkocher dkocher force-pushed the feature/GH-15137 branch from 46931fb to 310a91e Compare May 15, 2024 13:05
@ylangisc ylangisc modified the milestones: 8.9.0, 8.9.1 May 16, 2024
@dkocher dkocher merged commit b0a2ef1 into master May 27, 2024
6 checks passed
@dkocher dkocher deleted the feature/GH-15137 branch May 27, 2024 09:27
@AliveDevil AliveDevil mentioned this pull request Sep 20, 2024
Closed
AliveDevil added a commit that referenced this pull request Sep 20, 2024
@AliveDevil
Revert designer deletion of selection change committed handler (0123f72…
664b38e 
…, #15138)
@AliveDevil AliveDevil mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliveDevil AliveDevil AliveDevil approved these changes

@ylangisc ylangisc ylangisc approved these changes

Assignees

@ylangisc ylangisc

Labels
None yet
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

Provide preference to enable versioning of files edited in external application
3 participants
@dkocher @ylangisc @AliveDevil