Interoperability with macOS Tahoe

.gitignore

@@ -3,6 +3,7 @@ target
 !.idea/codeStyleSettings.xml
 !.idea/copyright
 *.iml
+xcuserdata/*
 
 # VSCode/Java #
 ###############

CHANGELOG.md

@@ -5,6 +5,7 @@
 * [Feature] Connect with Multi-Bucket Application Keys that grant access to a specific group of buckets within an
   account, including the option to limit access based on a single file prefix (
   B2) ([#17139](https://trac.cyberduck.io/ticket/17139))
+* [Feature] Support for Liquid Glass (macOS) ([#17459](https://trac.cyberduck.io/ticket/17459))
 * [Feature] Connect with connection profile obtaining temporary credentials from AWS Security Token Service (STS) by
   assuming role with optional Multi-Factor Authentication (MFA) input (
   S3) ([#17437](https://trac.cyberduck.io/ticket/17437))

Credits.rtf

@@ -39,8 +39,6 @@
 \cf3 		Synapticloop\
 \cf0 		{\field{\*\fldinst{HYPERLINK "http://zathras.de/"}}{\fldrslt UKCrashReporter}}\
 \cf3 		M. Uli Kusterer\
-\cf0 		{\field{\*\fldinst{HYPERLINK "http://www.snoize.com/"}}{\fldrslt SNDisclosableView}}\
-\cf3 		Kurt Revis\
 \cf0 		{\field{\*\fldinst{HYPERLINK "https://opensource.apple.com/tarballs/mDNSResponder/"}}{\fldrslt mDNSResponder}}\
 \cf3 		Apple Inc.\
 \cf0 		{\field{\*\fldinst{HYPERLINK "https://sparkle-project.org/"}}{\fldrslt Sparkle}}\

binding/src/main/java/ch/cyberduck/binding/BundleController.java

@@ -30,13 +30,17 @@
 import ch.cyberduck.core.Factory;
 import ch.cyberduck.core.FactoryException;
 
+import ch.cyberduck.core.LocaleFactory;
+
 import org.apache.commons.lang3.StringUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
 public abstract class BundleController extends ProxyController {
     private static final Logger log = LogManager.getLogger(BundleController.class);
 
+    protected static final String DEFAULT = LocaleFactory.localizedString("Default");
+
     public static final NSMutableParagraphStyle PARAGRAPH_STYLE_LEFT_ALIGNMENT_TRUNCATE_MIDDLE;
     public static final NSMutableParagraphStyle PARAGRAPH_STYLE_LEFT_ALIGNMENT_TRUNCATE_TAIL;
     public static final NSMutableParagraphStyle PARAGRAPH_STYLE_RIGHT_ALIGNMENT_TRUNCATE_TAIL;

binding/src/main/java/ch/cyberduck/binding/Outlet.java

@@ -22,7 +22,7 @@
 import java.lang.annotation.ElementType;
 import java.lang.annotation.RetentionPolicy;
 
-@java.lang.annotation.Target({ElementType.FIELD})
+@java.lang.annotation.Target({ElementType.FIELD, ElementType.METHOD})
 @java.lang.annotation.Retention(RetentionPolicy.SOURCE)
 public @interface Outlet {
 }

binding/src/main/java/ch/cyberduck/binding/ProxyController.java

@@ -17,9 +17,15 @@
 
 import ch.cyberduck.binding.application.NSAlert;
 import ch.cyberduck.binding.application.NSApplication;
+import ch.cyberduck.binding.application.NSPopover;
+import ch.cyberduck.binding.application.NSView;
+import ch.cyberduck.binding.application.NSViewController;
 import ch.cyberduck.binding.application.NSWindow;
 import ch.cyberduck.binding.application.SheetCallback;
 import ch.cyberduck.binding.application.WindowListener;
+import ch.cyberduck.binding.foundation.FoundationKitFunctions;
+import ch.cyberduck.binding.foundation.NSNotification;
+import ch.cyberduck.binding.foundation.NSObject;
 import ch.cyberduck.binding.foundation.NSThread;
 import ch.cyberduck.core.AbstractController;
 import ch.cyberduck.core.threading.DefaultMainAction;
@@ -28,11 +34,14 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.rococoa.ID;
+import org.rococoa.cocoa.foundation.NSRect;
+import org.rococoa.cocoa.foundation.NSSize;
 
 import java.util.HashSet;
 import java.util.Set;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicReference;
 
 import com.google.common.util.concurrent.Uninterruptibles;
 
@@ -153,6 +162,16 @@ public int alert(final SheetController sheet, final AlertRunner runner, final Co
     protected static final Set<AlertRunner> alerts
             = new HashSet<>();
 
+    /**
+     * @param sheet    Controller for alert window
+     * @param callback Handler invoked after sheet is dismissed with selected option
+     * @param runner   Implementation to display alert window
+     * @return Selected alert option by user
+     */
+    public int alert(final SheetController sheet, final SheetCallback callback, final AlertRunner runner) {
+        return this.alert(sheet, callback, runner, new CountDownLatch(1));
+    }
+
     /**
      * Display as sheet attached to window of parent controller
      *
@@ -164,7 +183,9 @@ public int alert(final SheetController sheet, final AlertRunner runner, final Co
      */
     public int alert(final SheetController sheet, final SheetCallback callback, final AlertRunner runner, final CountDownLatch signal) {
         log.debug("Alert with runner {} and callback {}", runner, callback);
-        alerts.add(runner);
+        synchronized(alerts) {
+            alerts.add(runner);
+        }
         final AtomicInteger option = new AtomicInteger(SheetCallback.CANCEL_OPTION);
         final CountDownLatch state = new CountDownLatch(1);
         final SheetCallback.DelegatingSheetCallback chain = new SheetCallback.DelegatingSheetCallback(new SheetCallback.ReturnCodeSheetCallback(option), sheet, callback);
@@ -174,7 +195,11 @@ public void run() {
                 log.info("Load bundle for alert {}", sheet);
                 sheet.loadBundle();
                 runner.alert(sheet.window(), new SheetCallback.DelegatingSheetCallback(new SignalSheetCallback(state),
-                        chain, new SignalSheetCallback(signal), (returncode) -> alerts.remove(runner)));
+                        chain, new SignalSheetCallback(signal), (returncode) -> {
+                    synchronized(alerts) {
+                        alerts.remove(runner);
+                    }
+                }));
             }
         }, true);
         if(!NSThread.isMainThread()) {
@@ -310,4 +335,109 @@ public void callback(final int returncode) {
             signal.countDown();
         }
     }
+
+    public static final class PopoverAlertRunner extends Proxy implements AlertRunner, AlertRunner.CloseHandler, WindowListener {
+        private final NSPopover popover = NSPopover.create();
+        private final NSView positioningView;
+        private final NSRect positioningRect;
+        private final SheetController controller;
+        private final AtomicReference<Proxy> reference = new AtomicReference<>();
+        private final AtomicInteger option = new AtomicInteger(SheetCallback.CANCEL_OPTION);
+        private final int behaviour;
+
+        public PopoverAlertRunner(final NSView positioningView, final SheetController controller) {
+            this(positioningView, positioningView.frame(), controller);
+        }
+
+        public PopoverAlertRunner(final NSView positioningView, final SheetController controller, final int behaviour) {
+            this(positioningView, positioningView.frame(), controller, behaviour);
+        }
+
+        public PopoverAlertRunner(final NSView positioningView, final NSRect positioningRect, final SheetController controller) {
+            this(positioningView, positioningRect, controller, NSPopover.NSPopoverBehaviorSemitransient);
+        }
+
+        public PopoverAlertRunner(final NSView positioningView, final NSRect positioningRect, final SheetController controller, final int behaviour) {
+            this.positioningView = positioningView;
+            this.positioningRect = positioningRect;
+            this.controller = controller;
+            this.controller.addHandler(this);
+            this.behaviour = behaviour;
+        }
+
+        @Override
+        public void alert(final NSWindow sheet, final SheetCallback callback) {
+            NSApplication.sharedApplication().activateIgnoringOtherApps(true);
+            final Proxy proxy = new PopoverDelegate(controller, option, callback);
+            reference.set(proxy);
+            popover.setDelegate(proxy.id());
+            popover.setAnimates(false);
+            popover.setBehavior(behaviour);
+            final NSViewController viewController = NSViewController.create();
+            viewController.setView(sheet.contentView());
+            popover.setContentViewController(viewController);
+            popover.showRelativeToRect_ofView_preferredEdge(positioningRect, positioningView,
+                    FoundationKitFunctions.NSRectEdge.NSMinYEdge);
+            controller.addListener(this);
+        }
+
+        @Override
+        public void windowDidResize(final NSSize windowFrame) {
+            log.debug("Resize popover to {}", windowFrame);
+            final NSSize intrinsicContentSize = controller.view().intrinsicContentSize();
+            // Adjust height only
+            popover.setContentSize(new NSSize(popover.contentSize().width.doubleValue(), intrinsicContentSize.height.doubleValue()));
+        }
+
+        @Override
+        public void closed(final NSWindow sheet, final int returncode) {
+            option.set(returncode);
+            popover.performClose(null);
+        }
+    }
+
+    public static final class PopoverDelegate extends Proxy {
+        private final SheetController controller;
+        private final AtomicInteger returncode;
+        private final SheetCallback callback;
+
+        public PopoverDelegate(final SheetController controller, final AtomicInteger returncode, final SheetCallback callback) {
+            this.controller = controller;
+            this.returncode = returncode;
+            this.callback = callback;
+        }
+
+        @Delegate
+        public void popoverWillClose(final NSNotification notification) {
+            final NSObject popoverCloseReasonValue = notification.userInfo().objectForKey(NSPopover.NSPopoverCloseReasonKey);
+            if(popoverCloseReasonValue != null) {
+                if(NSPopover.NSPopoverCloseReasonValue.NSPopoverCloseReasonStandard.equals(popoverCloseReasonValue.toString())) {
+                    log.debug("Notify {} of return code {}", callback, returncode.get());
+                    // No window close notification for popover
+                    controller.invalidate();
+                    callback.callback(returncode.get());
+                }
+                else {
+                    log.debug("Ignore notification {}", notification);
+                }
+            }
+        }
+
+        @Delegate
+        public boolean popoverShouldDetach(final NSPopover popover) {
+            return true;
+        }
+    }
+
+    /**
+     * Adjust frame of subview to match the parent view and attach with translating autoresizing mask into constraints
+     *
+     * @param parent  Container View
+     * @param subview Content View
+     */
+    protected void addSubview(final NSView parent, final NSView subview) {
+        subview.setTranslatesAutoresizingMaskIntoConstraints(true);
+        subview.setFrame(parent.bounds());
+        parent.addSubview(subview);
+    }
 }

binding/src/main/java/ch/cyberduck/binding/SheetController.java

@@ -75,12 +75,10 @@ public void closeSheet(final NSButton sender) {
     public void closeSheetWithOption(int option) {
         log.debug("Close sheet with option {}", option);
         window.endEditingFor(null);
-        if(option == SheetCallback.DEFAULT_OPTION || option == SheetCallback.ALTERNATE_OPTION) {
-            if(!this.validate(option)) {
-                log.warn("Failed validation with option {}", option);
-                AppKitFunctionsLibrary.beep();
-                return;
-            }
+        if(!this.validate(option)) {
+            log.warn("Failed validation with option {}", option);
+            AppKitFunctionsLibrary.beep();
+            return;
         }
         handlers.forEach(h -> h.closed(window, option));
     }

binding/src/main/java/ch/cyberduck/binding/WindowController.java

@@ -47,8 +47,6 @@
 public abstract class WindowController extends BundleController implements NSWindow.Delegate {
     private static final Logger log = LogManager.getLogger(WindowController.class);
 
-    protected static final String DEFAULT = LocaleFactory.localizedString("Default");
-
     protected final Set<WindowListener> listeners
             = Collections.synchronizedSet(new HashSet<>());
     /**
@@ -89,6 +87,7 @@ public void setWindow(final NSWindow window) {
         this.window.recalculateKeyViewLoop();
         this.window.setReleasedWhenClosed(true);
         this.window.setDelegate(this.id());
+        this.window.setLevel(NSWindow.NSWindowLevel.NSNormalWindowLevel);
         this.window.setCollectionBehavior(window.collectionBehavior()
                 | NSWindow.NSWindowCollectionBehavior.NSWindowCollectionBehaviorTransient);
     }

binding/src/main/java/ch/cyberduck/binding/application/NSPopover.java

@@ -102,6 +102,14 @@ public static NSPopover create() {
      */
     public abstract void setContentViewController(NSViewController controller);
 
+    /**
+     * You must set the content view controller of the popover before the popover is shown. Changes to the popover’s content
+     * view controller while the popover is shown will cause the popover to animate if the animates property is true.
+     *
+     * @return The view controller that manages the content of the popover.
+     */
+    public abstract NSViewController contentViewController();
+
     /**
      * Shows the popover anchored to the specified view.
      * <p>

binding/src/main/java/ch/cyberduck/binding/application/NSTableView.java

@@ -27,9 +27,11 @@
 import ch.cyberduck.binding.foundation.NSURL;
 
 import org.rococoa.ID;
+import org.rococoa.Selector;
 import org.rococoa.cocoa.CGFloat;
 import org.rococoa.cocoa.foundation.NSInteger;
 import org.rococoa.cocoa.foundation.NSPoint;
+import org.rococoa.cocoa.foundation.NSRect;
 import org.rococoa.cocoa.foundation.NSUInteger;
 
 /// <i>native declaration : :69</i>
@@ -260,6 +262,20 @@ public interface Delegate {
      */
     public abstract CGFloat rowHeight();
 
+    /**
+     *
+     * @param enable A Boolean value that indicates whether the table view uses autolayout to calculate the height of rows.
+     * @since macOS 10.13+
+     */
+    public abstract void setUsesAutomaticRowHeights(boolean enable);
+
+    /**
+     *
+     * @return A Boolean value that indicates whether the table view uses autolayout to calculate the height of rows.
+     * @since macOS 10.13+
+     */
+    public abstract boolean usesAutomaticRowHeights();
+
     /**
      * If the delegate implements -tableView:heightOfRow:, this method immediately re-tiles the table view using row
      * heights it provides.<br> Original signature : <code>void noteHeightOfRowsWithIndexesChanged(NSIndexSet*)</code><br>
@@ -394,13 +410,13 @@ public interface Delegate {
      * Original signature : <code>void setDoubleAction(SEL)</code><br>
      * <i>native declaration : :175</i>
      */
-    public abstract void setDoubleAction(org.rococoa.Selector aSelector);
+    public abstract void setDoubleAction(Selector aSelector);
 
     /**
      * Original signature : <code>SEL doubleAction()</code><br>
      * <i>native declaration : :176</i>
      */
-    public abstract org.rococoa.Selector doubleAction();
+    public abstract Selector doubleAction();
 
     /**
      * Sorting Support<br> The array of sort descriptors is archived.  Sort descriptors will persist along with other
@@ -841,4 +857,14 @@ public void editRow(NSInteger column, NSInteger row, boolean select) {
      * <i>from NSDeprecated native declaration : :528</i><br>
      * Conversion Error : NSRect
      */
+
+    /**
+     * Returns the rectangle containing the row at the specified index.
+     *
+     * @param row Table row
+     * @return The rectangle containing the row at rowIndex. Returns NSZeroRect if rowIndex lies outside the
+     * range of valid row indexes for the table view.
+     */
+    public abstract NSRect rectOfRow(NSInteger row);
+
 }

binding/src/main/java/ch/cyberduck/binding/application/NSUserInterfaceItemIdentification.java

@@ -0,0 +1,31 @@
+package ch.cyberduck.binding.application;
+
+/*
+ * Copyright (c) 2002-2025 iterate GmbH. All rights reserved.
+ * https://cyberduck.io/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+public interface NSUserInterfaceItemIdentification {
+
+    /**
+     *
+     * @return A string that identifies the user interface item.
+     */
+    String identifier();
+
+    /**
+     *
+     * @param identifier A string that identifies the user interface item.
+     */
+    void setIdentifier(String identifier);
+}