Visual mode bug fix #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior if you try to complete :e %:p:h or something similar replaces only the h with the path, which isn't the desired behavior, because then nvim tries to open the wrong filename. Detect this case and produce edits that will replace the entire `%` chain with modifiers.
|
The |
|
I just pushed up a better fix to my branch. Hopefully that will work for you. I'm going to close this, but feel free to open another PR if you have additional fixes. |
|
You may also want hrsh7th/nvim-cmp#1900 until it gets merged. I found it while doing some debugging to remember why I stripped out |
|
works like a charm thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to do two things:
%autocomplete; we cannot live without it XD while a small bug with visual mode where the current behaviordoesn't take into consideration what already has been typed into the cmdline
No it's better
My initial testing went OK, no problems so far.