Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overhaul runners, add GCP & K8s stubs #105

Merged
merged 10 commits into from
Sep 17, 2021
Merged

overhaul runners, add GCP & K8s stubs #105

merged 10 commits into from
Sep 17, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Sep 14, 2021 •
edited
Loading

@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 14, 2021 17:49 Inactive
@0x2b3bfa0 0x2b3bfa0 self-requested a review September 14, 2021 17:50
@casperdcl casperdcl self-assigned this Sep 14, 2021
@casperdcl casperdcl changed the title runners overhaul runners, add GCP & K8s stubs Sep 14, 2021
@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 14, 2021 18:07 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 14, 2021 18:34 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 14, 2021 18:41 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 14, 2021 18:48 Inactive
@casperdcl casperdcl mentioned this pull request Sep 14, 2021
Closed
4 tasks
casperdcl
casperdcl commented Sep 14, 2021
View reviewed changes
content/docs/self-hosted-runners.md
Comment on lines +248 to +250
<details>

#### GCP
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julieg18 is there any way to get this pattern to work with #ids? i.e [link](/doc/self-hosted-runners#gcp)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in our current version of the doc-engine. Headers inside the details block work but not the details's header itself. We currently take off the auto link headers inside the details headers since it doesn't work correctly. But looking at the html and css, it may be possible to implement this if we wanted 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice; but #70 is much more urgent :)

@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 14, 2021 19:41 Inactive
@casperdcl casperdcl added p1-important High priority documentation Markdown files labels Sep 15, 2021
0x2b3bfa0
0x2b3bfa0 reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to address / dismiss my nitpicks and :shipit:

@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 17, 2021 10:26 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 17, 2021 10:42 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-runners-aizqrfo8lnujsk September 17, 2021 10:59 Inactive
0x2b3bfa0
0x2b3bfa0 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@casperdcl casperdcl merged commit 0253495 into master Sep 17, 2021
@casperdcl casperdcl deleted the runners branch September 17, 2021 11:04
casperdcl added a commit to iterative/cml that referenced this pull request Sep 17, 2021
@casperdcl
readme: misc updates
83c6489 
- sync with iterative/cml.dev#105
@casperdcl casperdcl mentioned this pull request Sep 17, 2021
Merged
0x2b3bfa0 pushed a commit to iterative/cml that referenced this pull request Sep 17, 2021
@casperdcl
readme: misc updates (#717)
2e9a21d 
- sync with iterative/cml.dev#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julieg18 julieg18 julieg18 left review comments

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@casperdcl casperdcl

Labels
documentation Markdown files p1-important High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@casperdcl @0x2b3bfa0 @julieg18 @shcheklein