Pull request creation not working on subdirectories #1344
Assignees
Labels
Comments
cameronraysmith
added a commit
to cameronraysmith/pyrovelocity
that referenced
this issue
Feb 12, 2023
* doesn't recognize changes in subdirectories * see iterative/cml#1344 * `npx github:iterative/cml#b923f3e pr create` or similar
cameronraysmith
added a commit
to cameronraysmith/pyrovelocity
that referenced
this issue
Feb 13, 2023
* https://github.com/iterative/cml/actions/runs/4161324906/jobs/7199287839 11 hours ago * workflow https://github.com/iterative/cml/blob/ee8834ba6d37816dff01acf5f65432a3725326c5/.github/workflows/images.yml#L26 * checking fix iterative/cml#1344 * support removal of `npx github:iterative/cml#b923f3e pr create --skip-ci .`
cameronraysmith
added a commit
to pinellolab/pyrovelocity
that referenced
this issue
Feb 16, 2023
* add optional tmate debugging to cml workflow * https://github.com/mxschmitt/action-tmate * restrict cml to run on push to `exp*` branches * restrict cml to run on push to relevant paths - "pyrovelocity/**" - "reproducibility/figures/*.py" - "reproducibility/figures/dvc.*" - "reproducibility/figures/config.yaml" * define environment variables in cml workflow * REPO_TOKEN * GOOGLE_APPLICATION_CREDENTIALS_DATA * GCP_SERVICE_ACCOUNT * MLFLOW_TRACKING_PASSWORD * MLFLOW_TRACKING_URI * MLFLOW_TRACKING_USERNAME * TF_LOG_PROVIDER * lint cml.yml * add setup-cml step * https://github.com/iterative/setup-cml * update cml env var comments * disable tmate debug before runner deployment * add train-model job * remove setup of additional python * workaround for iterative/cml#1344 * doesn't recognize changes in subdirectories * see iterative/cml#1344 * `npx github:iterative/cml#b923f3e pr create` or similar * update workflow comments * use `dvc repro` by default * note option to swap for `dvc exp run` if you want to test changes without committing to exp branch * reference issues requiring workarounds * test `workflow_dispatch` inputs context * `github.event.inputs` --> `inputs` * see * https://github.blog/changelog/2022-06-10-github-actions-inputs-unified-across-manual-and-reusable-workflows/ * community/community#9343 (comment) * separate debug sessions for deploy and model * `deploy_debug_enabled` * `model_debug_enabled` * test updated cml container * https://github.com/iterative/cml/actions/runs/4161324906/jobs/7199287839 11 hours ago * workflow https://github.com/iterative/cml/blob/ee8834ba6d37816dff01acf5f65432a3725326c5/.github/workflows/images.yml#L26 * checking fix iterative/cml#1344 * support removal of `npx github:iterative/cml#b923f3e pr create --skip-ci .` * use repo package * cycle gcp zone c --> a * `ghcr.io/cameronraysmith/pyrovelocity:master` * use upstream docker image * test iteration over zones * use bash env var * actions env var may require different syntax to function as array indexed by "[@]" in loop * use `break 2` instead of exit * include upstream fix (#4) * add boilerplate pre-commit.ci config https://pre-commit.ci/#configuration * relocate cml experiment to pipeline script * `cml.yaml` --> `./.github/pipeline.sh` * add loss plots to dvc outputs * add pre-commit local configuration * upgrade pre-commit prettier * https://github.com/pre-commit/mirrors-prettier/issues/29#issuecomment-1332667344 * use remote hooks by default * temporarily install `matplotlib-venn` * increase memory * `n1-standard-16` --> `n1-standard-32` * use gnu time with training * print pipeline files * CML PR for 9f7bd1e [skip ci] (#7) see #58 Co-authored-by: Olivaw[bot] <olivaw@iterative.ai> * use html image links in README * for compatibility with PyPI rendering --------- Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org> Co-authored-by: Olivaw[bot] <olivaw@iterative.ai>
cameronraysmith
added a commit
to pinellolab/pyrovelocity
that referenced
this issue
Jan 3, 2024
* add optional tmate debugging to cml workflow * https://github.com/mxschmitt/action-tmate * restrict cml to run on push to `exp*` branches * restrict cml to run on push to relevant paths - "pyrovelocity/**" - "reproducibility/figures/*.py" - "reproducibility/figures/dvc.*" - "reproducibility/figures/config.yaml" * define environment variables in cml workflow * REPO_TOKEN * GOOGLE_APPLICATION_CREDENTIALS_DATA * GCP_SERVICE_ACCOUNT * MLFLOW_TRACKING_PASSWORD * MLFLOW_TRACKING_URI * MLFLOW_TRACKING_USERNAME * TF_LOG_PROVIDER * lint cml.yml * add setup-cml step * https://github.com/iterative/setup-cml * update cml env var comments * disable tmate debug before runner deployment * add train-model job * remove setup of additional python * workaround for iterative/cml#1344 * doesn't recognize changes in subdirectories * see iterative/cml#1344 * `npx github:iterative/cml#b923f3e pr create` or similar * update workflow comments * use `dvc repro` by default * note option to swap for `dvc exp run` if you want to test changes without committing to exp branch * reference issues requiring workarounds * test `workflow_dispatch` inputs context * `github.event.inputs` --> `inputs` * see * https://github.blog/changelog/2022-06-10-github-actions-inputs-unified-across-manual-and-reusable-workflows/ * community/community#9343 (comment) * separate debug sessions for deploy and model * `deploy_debug_enabled` * `model_debug_enabled` * test updated cml container * https://github.com/iterative/cml/actions/runs/4161324906/jobs/7199287839 11 hours ago * workflow https://github.com/iterative/cml/blob/ee8834ba6d37816dff01acf5f65432a3725326c5/.github/workflows/images.yml#L26 * checking fix iterative/cml#1344 * support removal of `npx github:iterative/cml#b923f3e pr create --skip-ci .` * use repo package * cycle gcp zone c --> a * `ghcr.io/cameronraysmith/pyrovelocity:master` * use upstream docker image * test iteration over zones * use bash env var * actions env var may require different syntax to function as array indexed by "[@]" in loop * use `break 2` instead of exit * include upstream fix (#4) * add boilerplate pre-commit.ci config https://pre-commit.ci/#configuration * relocate cml experiment to pipeline script * `cml.yaml` --> `./.github/pipeline.sh` * add loss plots to dvc outputs * add pre-commit local configuration * upgrade pre-commit prettier * https://github.com/pre-commit/mirrors-prettier/issues/29#issuecomment-1332667344 * use remote hooks by default * temporarily install `matplotlib-venn` * increase memory * `n1-standard-16` --> `n1-standard-32` * use gnu time with training * print pipeline files * CML PR for 9f7bd1e [skip ci] (#7) see #58 Co-authored-by: Olivaw[bot] <olivaw@iterative.ai> * use html image links in README * for compatibility with PyPI rendering --------- Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org> Co-authored-by: Olivaw[bot] <olivaw@iterative.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like
cml pr createis failing to detect files when running from directories other than the repository root.The text was updated successfully, but these errors were encountered: