-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitLab driver branch fetch is using deprecated GitLab CI environment variables #1403
Comments
nipierre
changed the title
New Feature
GitLab driver branch fetch is using deprecated GitLab CI environment variables
Jul 19, 2023
@nipierre good catch! @ mention me when you create your PR and I'll prioritize getting it merged and released |
nipierre
added a commit
to nipierre/cml
that referenced
this issue
Jul 20, 2023
GitLab 16.x deprecated several variables including CI_BUILD_REF_NAME. In order to be exhaustive, two variables are replacing it: CI_COMMIT_BRANCH (prefered) and CI_COMMIT_REF_NAME. Issue: iterative#1403
dacbd
added a commit
that referenced
this issue
Jul 26, 2023
* fix: replace deprecated gitlab ci var GitLab 16.x deprecated several variables including CI_BUILD_REF_NAME. In order to be exhaustive, two variables are replacing it: CI_COMMIT_BRANCH (prefered) and CI_COMMIT_REF_NAME. Issue: #1403 * Update src/drivers/gitlab.js * ci: add expires_at in gitlab credentials --------- Co-authored-by: Daniel Barnes <dabarnes2b@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary / Background
The GitLab driver is using a deprecated environment variable to fetch branch name (namely
CI_BUILD_REF_NAME
).Scope
Users using CML on GitLab 16.x.
Assumptions
Should be replaced by either
CI_COMMIT_REF_NAME
orCI_COMMIT_BRANCH
.Open Questions
Blockers / Dependencies
General Approach
In GitLab CI:
cml pr .
Ends up with:
Timelines
I can push a fix by the end of the week.
The text was updated successfully, but these errors were encountered: