GitLab - check comment body size #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacbd
changed the title
GitLab check comment body size
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
casperdcl
reviewed
Feb 13, 2023
tasdomas
previously approved these changes
Feb 14, 2023
|
To address the warn vs error. To my knowledge, only GitHub provides a native means to supply these notifications, and this is specific to GitLab. As far as logging vs an error. The issue the user brought up made it seem like this more or less silently failed, so I think exiting with a non-zero status code is the best option. How are we going to truncate the report? I don't think we can realistically decide for the user what to drop especially since this is most likely coming from the use of the |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
casperdcl
previously requested changes
Feb 14, 2023
dacbd
commented
Feb 14, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Test Comment |
Test Comment |
Test Comment |
13 similar comments
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.gitlab.com/ee/api/notes.html#create-new-merge-request-note
Closes: #1348