Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing backslash on container ENTRYPOINT #726

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Sep 21, 2021

Silly mistake that I missed when reviewing #716: if ENTRYPOINT doesn't contain a valid JSON array, it's going to be interpreted as a shell command, producing errors like the following:

sh: [/bin/bash,: No such file or directory

It's breaking all our GitLab tests, but it should not, as CML has not been released since July 28th. 🤔 Has somebody manually deployed our container images lately?

@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p0-critical Max priority (ASAP) labels Sep 21, 2021
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl September 21, 2021 17:14
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 21, 2021
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 21, 2021 17:14 Inactive
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@0x2b3bfa0 0x2b3bfa0 merged commit d1daa8d into master Sep 21, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the fix-entrypoint branch September 21, 2021 17:19
@0x2b3bfa0
Copy link
Member Author

Merging with GitLab tests in red for obvious reasons.

@casperdcl
Copy link
Contributor

The docker images are deployed both on release & on schedule to grab updates.

push:
${{ github.event_name == 'release' || github.event_name ==
'schedule' }}

@0x2b3bfa0
Copy link
Member Author

🤦🏼 (my turn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0-critical Max priority (ASAP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants