Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2.xlarge/g2.2xlarge => g4dn.xlarge #780

Merged
merged 1 commit into from
Oct 26, 2021
Merged

p2.xlarge/g2.2xlarge => g4dn.xlarge #780

merged 1 commit into from
Oct 26, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Oct 26, 2021

because it's (slightly) cheaper :)

@casperdcl casperdcl self-assigned this Oct 26, 2021
@casperdcl casperdcl requested a review from 0x2b3bfa0 October 26, 2021 18:49
@casperdcl casperdcl temporarily deployed to internal October 26, 2021 18:49 Inactive
@casperdcl casperdcl changed the title g2.2xlarge => g4dn.xlarge p2.xlarge/g2.2xlarge => g4dn.xlarge Oct 26, 2021
@casperdcl casperdcl added technical-debt Refactoring, linting & tidying testing Unit tests & debugging labels Oct 26, 2021
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes the tests and we pay 20% less. Looks awesome to me!

@0x2b3bfa0 0x2b3bfa0 merged commit 2ed8e4d into master Oct 26, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the ec2-instaces branch October 26, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Refactoring, linting & tidying testing Unit tests & debugging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants