Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cml runner allow for a user set subnet #831

Merged
merged 5 commits into from
Dec 18, 2021

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Dec 3, 2021

Follow up for: iterative/terraform-provider-iterative#323 when complete.

Closes #795

Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DavidGOrtega DavidGOrtega temporarily deployed to external December 17, 2021 12:18 Inactive
@DavidGOrtega
Copy link
Contributor

@dacbd 🙏
Is this ready?

@dacbd
Copy link
Contributor Author

dacbd commented Dec 17, 2021

I'm 98% sure it's good, but I plan to play with it today, I'll mark ready after.

@dacbd
Copy link
Contributor Author

dacbd commented Dec 17, 2021

@DavidGOrtega I am satisfied

tested with:

./bin/cml.js runner \
    --single \
    --idle-timeout=360 \
    --token=*** \
    --cloud=aws \
    --cloud-region=us-west-2 \
    --cloud-type=t3.medium \
    --repo=https://github.com/P*** \
    --cloud-aws-security-group=github-actions-test \
    --cloud-aws-subnet-id=subnet-06ee5a8e940002c2d \
    --driver=github

and worked as expected.

I'll probably put together a little demo of all these features I've pushed if interested.

@dacbd dacbd marked this pull request as ready for review December 17, 2021 16:37
@DavidGOrtega DavidGOrtega temporarily deployed to external December 18, 2021 15:38 Inactive
@DavidGOrtega DavidGOrtega merged commit 6510e27 into iterative:master Dec 18, 2021
casperdcl added a commit to iterative/cml.dev that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Dependent on something else cloud-aws Amazon Web Services cml-runner Subcommand
Projects
None yet
3 participants