Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone pkg #842

Merged
merged 21 commits into from
Dec 17, 2021
Merged

Standalone pkg #842

merged 21 commits into from
Dec 17, 2021

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented Dec 14, 2021

mmagic dependency removed using a wasm version of libmagic.

@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 11:02 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 11:06 Inactive
@DavidGOrtega DavidGOrtega self-assigned this Dec 14, 2021
@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 11:15 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 12:50 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 13:50 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 15:12 Inactive
@DavidGOrtega
Copy link
Contributor Author

DavidGOrtega commented Dec 14, 2021

@iterative/cml we are suffering an strange hiccup while testing doing npm i -g

  npm i -g
  cml --version
  cml runner --version
  cml publish --version
  cml pr --version
  shell: /usr/bin/bash -e {0}

added 1 package, and audited 3 packages in 2s

found 0 vulnerabilities
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module 'pseudoexec'
Require stack:
- /home/runner/work/cml/cml/bin/cml.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/runner/work/cml/cml/bin/cml.js:4:24)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/runner/work/cml/cml/bin/cml.js' ]

@casperdcl casperdcl temporarily deployed to internal December 14, 2021 16:07 Inactive
@casperdcl casperdcl temporarily deployed to internal December 14, 2021 16:12 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 16:19 Inactive
@DavidGOrtega
Copy link
Contributor Author

@casperdcl casperdcl force-pushed the standalone-pkg branch from f8236fa to 541009c 8 minutes ago

I tried the same in 4e802d1 @casperdcl

@DavidGOrtega DavidGOrtega temporarily deployed to internal December 14, 2021 16:22 Inactive
@casperdcl casperdcl temporarily deployed to internal December 14, 2021 16:31 Inactive
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on #847 <- #845

@casperdcl casperdcl temporarily deployed to internal December 16, 2021 14:27 Inactive
@casperdcl casperdcl temporarily deployed to internal December 16, 2021 14:31 Inactive
@casperdcl casperdcl self-requested a review December 16, 2021 14:31
@casperdcl
Copy link
Contributor

casperdcl commented Dec 16, 2021

GitLab failing with Error: Failed creating the machine: no Subnet found - maybe related to iterative/terraform-provider-iterative#323?

stderr
{"level":"error","message":"terraform -chdir=/home/runner apply -auto-approve
	
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
 + create

Terraform will perform the following actions:

 # iterative_cml_runner.runner will be created
 + resource "iterative_cml_runner" "runner" {
 + cloud = "aws"
 + driver = "gitlab"
 + id = (known after apply)
 + idle_timeout = 300
 + image = (known after apply)
 + instance_hdd_size = 35
 + instance_ip = (known after apply)
 + instance_launch_time = (known after apply)
 + instance_type = "g4dn.xlarge"
 + labels = "cml-runner-gpu"
 + name = "cml-jy7luixvvc"
 + region = "us-west"
 + repo = "https://gitlab.com/iterative.ai/cml"
 + single = false
 + spot = true
 + spot_price = -1
 + ssh_public = (known after apply)
 + token = (sensitive value)
 }

Plan: 1 to add, 0 to change, 0 to destroy.
iterative_cml_runner.runner: Creating...
iterative_cml_runner.runner: Still creating... [10s elapsed]

	╷
│ Error: Failed creating the machine: no Subnet found
│ 
│  with iterative_cml_runner.runner,
│  on main.tf line 14, in resource "iterative_cml_runner" "runner":
│  14: resource "iterative_cml_runner" "runner" {
│ 
╵
","stack":"Error: terraform -chdir=/home/runner apply -auto-approve
	
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
 + create

Terraform will perform the following actions:

 # iterative_cml_runner.runner will be created
 + resource "iterative_cml_runner" "runner" {
 + cloud = "aws"
 + driver = "gitlab"
 + id = (known after apply)
 + idle_timeout = 300
 + image = (known after apply)
 + instance_hdd_size = 35
 + instance_ip = (known after apply)
 + instance_launch_time = (known after apply)
 + instance_type = "g4dn.xlarge"
 + labels = "cml-runner-gpu"
 + name = "cml-jy7luixvvc"
 + region = "us-west"
 + repo = "https://gitlab.com/iterative.ai/cml"
 + single = false
 + spot = true
 + spot_price = -1
 + ssh_public = (known after apply)
 + token = (sensitive value)
 }

Plan: 1 to add, 0 to change, 0 to destroy.
iterative_cml_runner.runner: Creating...
iterative_cml_runner.runner: Still creating... [10s elapsed]

	╷
│ Error: Failed creating the machine: no Subnet found
│ 
│  with iterative_cml_runner.runner,
│  on main.tf line 14, in resource "iterative_cml_runner" "runner":
│  14: resource "iterative_cml_runner" "runner" {
│ 
╵

 at /usr/lib/node_modules/@dvcorg/cml/src/utils.js:14:27
 at ChildProcess.exithandler (node:child_process:404:5)
 at ChildProcess.emit (node:events:390:28)
 at maybeClose (node:internal/child_process:1064:16)
 at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)","status":"terminated"}

@dacbd
Copy link
Contributor

dacbd commented Dec 16, 2021

🤔 shouldn't be, that tf template shouldn't have touched any of the additional code paths I added. Has there been any changes to the "default" vpc for this test AWS account?

@DavidGOrtega
Copy link
Contributor Author

🤔 shouldn't be, that tf template shouldn't have touched any of the additional code paths I added. Has there been any changes to the "default" vpc for this test AWS account

None at all

@DavidGOrtega
Copy link
Contributor Author

/tests

@dacbd
Copy link
Contributor

dacbd commented Dec 16, 2021

/tests

cml runner vs cml-runner?

@DavidGOrtega
Copy link
Contributor Author

@dacbd both works

@dacbd
Copy link
Contributor

dacbd commented Dec 16, 2021

@casperdcl casperdcl temporarily deployed to internal December 17, 2021 09:33 Inactive
@casperdcl
Copy link
Contributor

Hoped it would be fixed by iterative/terraform-provider-iterative#336 <- iterative/terraform-provider-iterative#335 but still failing

@DavidGOrtega
Copy link
Contributor Author

Hoped it would be fixed by iterative/terraform-provider-iterative#336 <- iterative/terraform-provider-iterative#335 but still failing

Terraform did not updated the registry at that time. Now works as expected

@DavidGOrtega DavidGOrtega mentioned this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Dependent on something else releases Shipping builds technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CML binaries to improve the node dep replace/remove mmmagic dependency
4 participants