-
Notifications
You must be signed in to change notification settings - Fork 4
Add video example #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we work with a local storage there? it should cloud
can it be w/o output - it looks heavy for such a basic task. Can it be a single model - File + Meta (not sure how to organize it better tbh)
can we avoid creating a data model explicitly? from_csv should be able to figure out the schema and create Pydantic model for us
should be part of some helper ... ideally for saving a frame we don't have to do UDFs |
Updated example to work with cloud (including upload).
|
Done, fixed. The reason why it wasn't working before is because of typings in function definition. Before: if TYPE_CHECKING:
from datachain.lib.file import Video, VideoFile
def video_info(file: "VideoFile") -> "Video": After: from datachain.lib.file import Video, VideoFile
def video_info(file: VideoFile) -> Video: |
We can not in this case, because this CSV file does not have headers :( |
Video example for iterative/datachain#890
Note: This PR is also required: iterative/datachain#900