-
Notifications
You must be signed in to change notification settings - Fork 97
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return url for file in GCP public bucket instead of error
- Loading branch information
1 parent
cf05881
commit 035a2fc
Showing
2 changed files
with
16 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,6 @@ | ||
from datachain.client import Client | ||
|
||
|
||
def test_anon_url(mocker): | ||
def sign(*args, **kwargs): | ||
raise AttributeError( | ||
"you need a private key to sign credentials." | ||
"the credentials you are currently using" | ||
" <class 'google.oauth2.credentials.Credentials'> just contains a token." | ||
" see https://googleapis.dev/python/google-api-core/latest/auth.html" | ||
"#setting-up-a-service-account for more details." | ||
) | ||
|
||
mocker.patch("gcsfs.GCSFileSystem.sign", side_effect=sign) | ||
|
||
def test_anon_url(): | ||
client = Client.get_client("gs://foo", None, anon=True) | ||
assert client.url("bar") == "https://storage.googleapis.com/foo/bar" |