Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign UniqueId #36

Closed
3 of 5 tasks
Tracked by #33
dmpetrov opened this issue Jul 1, 2024 · 0 comments · Fixed by #450
Closed
3 of 5 tasks
Tracked by #33

Redesign UniqueId #36

dmpetrov opened this issue Jul 1, 2024 · 0 comments · Fixed by #450
Assignees
@rlamy

Comments

@dmpetrov
Copy link
Member

dmpetrov commented Jul 1, 2024 •
edited by rlamy
Loading

  • Fit UniqueId to File/pydentic class hierarchy
    • Let's make something like class BaseFile(BaseModel) instead of UniqueId. File should be just class File(BaseFile).
    • Another alternative: Fit everything to File class and just stop using UniqueId.
  • stop using vtype
  • stop making location as String. It has to be list[dict] (or dict - depending on implementation)
  • add version to the hash
  • Remove dir_type

Note 1, let's not use owner signals at this moment.
Note 2, in case catalog class is needed, more general session should be used (which contains catalog inside).

It's a part of iterative/dvcx#1635
@dmpetrov dmpetrov mentioned this issue Jul 13, 2024
Closed
@dmpetrov dmpetrov transferred this issue from another repository Jul 13, 2024
This was referenced Jul 18, 2024
Merged
Merged
@rlamy rlamy mentioned this issue Aug 8, 2024
Merged
This was referenced Sep 11, 2024
Merged
Merged
rlamy added a commit that referenced this issue Sep 18, 2024
@rlamy
Replace UniqueId with File (#450)
ee43fd1 
* Use `File` instead of `UniqueId` everywhere, replace `Node.as_uid()` with `Node.to_file()`
  * Add `File._from_row()` replacing `Catalog._get_row_uid()`
  * Transfer `get_hash()` method from `UniqueId` to `File`
* Remove `UniqueId` class and `File.get_uid()`.
* Remove legacy tar handling code
* Split off `File.ensure_cached()` from `File.get_local_path()`

Fixes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlamy rlamy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace UniqueId with File iterative/datachain
2 participants
@rlamy @dmpetrov