Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Client.parse_url() #434

Closed
ilongin opened this issue Sep 12, 2024 · 0 comments · Fixed by #435
Closed

Refactor Client.parse_url() #434

ilongin opened this issue Sep 12, 2024 · 0 comments · Fixed by #435
Assignees

Comments

@ilongin
Copy link
Contributor

ilongin commented Sep 12, 2024

The problem with this method is that we are mostly using it just to split url to base one and path and we don't actually need Client instance as return. Client instance requires cache so currently .parse_url() requires it as well which makes it unhandy when using in places where we just need split url.

We should create separate method to split url and maybe rename this one to something related to Client object which is returned.

@ilongin ilongin self-assigned this Sep 12, 2024
@ilongin ilongin linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant