Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
Client.parse_url()
into two methods:def parse_url(source: str) -> tuple[StorageURI, str]:
-> just splitssource
into storage uri and relative path and doesn't returnClient
instance any more.def get_client(source: str, cache: DataChainCache, **kwargs) -> "Client":
-> returnsClient
instanceThis is done because in most of the places we were using old
.parse_url()
to split URL and didn't care aboutClient
instance, but becauseClient
instance was returned, some additional args likecache
were needed.Now we can use simpler merhod
.parse_url()
where we just need storage uri and path and.get_client()
where actualClient
instance is needed