Fix storage dependencies #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
616d02c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1c6f4bf.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-420-fix-storage-data.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 93 93
Lines 9981 9981
Branches 2060 2060
=======================================
Hits 8735 8735
Misses 885 885
Partials 361 361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rlamy
approved these changes
Sep 11, 2024
src/datachain/dataset.py
Outdated
| dependency_name = listing_uri_from_name(dataset_name) | ||
| client, _ = Client.parse_url( | ||
| listing_uri_from_name(dataset_name), | ||
| None, # type: ignore[arg-type] |
There was a problem hiding this comment.
Can we fix this instead of ignoring?
There was a problem hiding this comment.
Yes, this is on my plate for long time. I will see if it makes sense to do it in separate PR or this one
There was a problem hiding this comment.
Fix in separate PR #435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure we have only name of the bucket in storage dependencies, instead of bucket name + path.
Issue was starting to appear when we moved listing to app level with
DataChain.from_storage()Example:
This script generates storage dependency with name
s3://ldb-publicand before these changes it was generatings3://ldb-public/remote/data-lakes/