Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create util function to return multiple DataChain instances, each for added, deleted and modified value of chain diff #715

Open
ilongin opened this issue Dec 16, 2024 · 0 comments · May be fixed by #719
Assignees
Labels
enhancement New feature or request

Comments

@ilongin
Copy link
Contributor

ilongin commented Dec 16, 2024

Now that we have DataChain.compare() implemented, we need another util function to return specific chain based on diff column.

Interface will be:

def compare(
    left: "DataChain",
    right: "DataChain",
    on: Union[str, Sequence[str]],
    right_on: Optional[Union[str, Sequence[str]]] = None,
    compare: Optional[Union[str, Sequence[str]]] = None,
    right_compare: Optional[Union[str, Sequence[str]]] = None,
    added: bool = True,
    deleted: bool = True,
    modified: bool = True,
    unchanged: bool = False,
) -> "DataChain":
@ilongin ilongin added the enhancement New feature or request label Dec 16, 2024
@ilongin ilongin self-assigned this Dec 16, 2024
@ilongin ilongin linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant