Added toolkit compare
#719
Open
+246
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 87.44% 87.48% +0.03%
==========================================
Files 114 115 +1
Lines 10898 10928 +30
Branches 1499 1503 +4
==========================================
+ Hits 9530 9560 +30
Misses 990 990
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying datachain-documentation with
|
| Latest commit: |
29f744e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d60efed.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-715-toolkit-diff.datachain-documentation.pages.dev |
|
@skshetry @dreadatour can we please review this folks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
comparefunction to toolkit. It usesdatachain.lib.diff.compare()to compareDataChains and returns dictionary with values for each ofadded,removed,modifiedandunchangedchains. Each chain consists only of those changes that are related to it (addedonly has added fields,deletedonlydeleted fields etc.) Keys of dicts are shortcuts for each status:A,D,MandU`.Status column is removed from each resulting chain as it's not needed.
Also added
CompareStatusenum and replaced hardcoded status letters (A,D...) across the codebasej