-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename export_files() to to_storage() #859
Comments
One thing to keep in mind is that datachain/src/datachain/lib/file.py Line 41 in 143b4be
I don't particularly like the If I ignore different |
This renames the export files to to storage adding the support for the cloud destinations as well. With this change, the following code will work: ```py from datachain.lib.dc import DataChain ds = DataChain.from_storage("az://amrit-test-az/image.png") ds.save("az") ds.to_storage("gs://amrit-datachain-test/destination", placement="filename") ``` Closes #859
This renames the export files to to storage adding the support for the cloud destinations as well. With this change, the following code will work: ```py from datachain.lib.dc import DataChain ds = DataChain.from_storage("az://amrit-test-az/image.png") ds.save("az") ds.to_storage("gs://amrit-datachain-test/destination", placement="filename") ``` Closes #859
This renames the export files to to storage adding the support for the cloud destinations as well. With this change, the following code will work: ```py from datachain.lib.dc import DataChain ds = DataChain.from_storage("az://amrit-test-az/image.png") ds.save("az") ds.to_storage("gs://amrit-datachain-test/destination", placement="filename") ``` Closes #859
This renames the export files to to storage adding the support for the cloud destinations as well. With this change, the following code will work: ```py from datachain.lib.dc import DataChain ds = DataChain.from_storage("az://amrit-test-az/image.png") ds.save("az") ds.to_storage("gs://amrit-datachain-test/destination", placement="filename") ``` Closes #859
Description
export_files()
needs to be renamed in order to get a consistent naming withfrom_storages()
,to_parque()
,to_json()
etc. It's also need too support all params acceptable infrom_storage()
like cloud pathss3://mybkt/dir1/
Open question: should we do a bit opposite - rename
from_storage()
-->from_files()
,export_files()
-->to_files()
in order to get a consistency withfrom_parquet()
,from_json()
. It seems like a cleaner way.@iterative/datachain WDYT folks?
PS:
The text was updated successfully, but these errors were encountered: