Add file modes for binary/text #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
c22e781
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2cba755f.datachain-documentation.pages.dev |
| Branch Preview URL: | https://file-modes.datachain-documentation.pages.dev |
dberenbaum
commented
Jul 20, 2024
| source = IndexedFile(file=file, index=index) | ||
| yield [source, *record.values()] | ||
| index += 1 | ||
| with tqdm(desc="Parsed by pyarrow", unit=" rows") as pbar: |
There was a problem hiding this comment.
Unrelated, but added a progressbar here so parsing tables shows some progress
|
The author of this PR, dberenbaum, is not an activated member of this organization on Codecov. |
dmpetrov
approved these changes
Jul 20, 2024
skshetry
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods as suggested in #102 (comment).
I didn't change any of the existing API, and I don't know if we can drop having classes like
TextFileandImageFilebecause we need a default read mode for some operations. For example, if we have a multimodal dataset with both an image and text file joined in each row and want to pass this to pytorch, each file object needs to know whether to pass the contents to pytorch as a text or image.