-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't depend on datachain from PATH to exec processes #118
Conversation
Deploying datachain-documentation with Cloudflare Pages
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 86.85% 86.86% +0.01%
==========================================
Files 88 88
Lines 9378 9379 +1
Branches 1879 1879
==========================================
+ Hits 8145 8147 +2
+ Misses 900 899 -1
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the executable PATH changes are fine by me, as long as they work on the Studio environment. And it also looks like Studio changes will be necessary, as the ClickHouse tests are failing with:
Local Worker Error: usage: datachain [-h] [-V] command ...
datachain: error: the following arguments are required: command
Which sounds like the Studio / ClickHouse code needs to be updated to use the new argument design (if that part of the PR is kept).
Also turns internal udf runner option into subcommands.
Also turns internal udf runner option into subcommands.