Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't depend on datachain from PATH to exec processes #118

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

skshetry
Copy link
Member

Also turns internal udf runner option into subcommands.

Copy link

cloudflare-workers-and-pages bot commented Jul 22, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a921d3
Status: ✅  Deploy successful!
Preview URL: https://2eee2553.datachain-documentation.pages.dev
Branch Preview URL: https://no-path.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.86%. Comparing base (aa8f352) to head (5a921d3).

Files Patch % Lines
src/datachain/utils.py 50.00% 1 Missing and 1 partial ⚠️
src/datachain/cli.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   86.85%   86.86%   +0.01%     
==========================================
  Files          88       88              
  Lines        9378     9379       +1     
  Branches     1879     1879              
==========================================
+ Hits         8145     8147       +2     
+ Misses        900      899       -1     
  Partials      333      333              
Flag Coverage Δ
datachain 86.80% <72.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry requested review from dtulga and rlamy July 22, 2024 03:14
@skshetry skshetry marked this pull request as ready for review July 22, 2024 03:15
@skshetry skshetry changed the title don't depend on datachain from path to exec processes don't depend on datachain from PATH to exec processes Jul 22, 2024
Copy link
Contributor

@dtulga dtulga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the executable PATH changes are fine by me, as long as they work on the Studio environment. And it also looks like Studio changes will be necessary, as the ClickHouse tests are failing with:

Local Worker Error: usage: datachain [-h] [-V] command ...
datachain: error: the following arguments are required: command

Which sounds like the Studio / ClickHouse code needs to be updated to use the new argument design (if that part of the PR is kept).

src/datachain/cli.py Outdated Show resolved Hide resolved
@skshetry skshetry requested a review from a team July 23, 2024 02:48
Also turns internal udf runner option into subcommands.
@skshetry skshetry merged commit 5312913 into main Jul 23, 2024
13 of 19 checks passed
@skshetry skshetry deleted the no-path branch July 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants