Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove get_value() from DataModel #119

Merged
merged 1 commit into from
Jul 22, 2024
Merged

remove get_value() from DataModel #119

merged 1 commit into from
Jul 22, 2024

Conversation

dmpetrov
Copy link
Member

@dmpetrov dmpetrov commented Jul 22, 2024

That's a forgotten part of File redesign #102

@dmpetrov dmpetrov requested a review from dberenbaum July 22, 2024 05:07
Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ebc6d9
Status: ✅  Deploy successful!
Preview URL: https://898486eb.datachain-documentation.pages.dev
Branch Preview URL: https://get-value.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (baec8e0) to head (1ebc6d9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          93       93           
  Lines        9468     9466    -2     
  Branches     1889     1889           
=======================================
- Hits         8100     8099    -1     
+ Misses       1039     1038    -1     
  Partials      329      329           
Flag Coverage Δ
datachain 85.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dberenbaum dberenbaum merged commit ba4a6bc into main Jul 22, 2024
19 checks passed
@dberenbaum dberenbaum deleted the get_value branch July 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants