merge/join: exclude sys signals #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
cd7e284
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8141dc46.datachain-documentation.pages.dev |
| Branch Preview URL: | https://merge-sys.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 85.69% 85.70% +0.01%
==========================================
Files 93 93
Lines 9477 9485 +8
Branches 1891 1893 +2
==========================================
+ Hits 8121 8129 +8
Misses 1024 1024
Partials 332 332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dmpetrov
requested changes
Jul 22, 2024
| @@ -92,7 +92,7 @@ def test_merge_similar_objects(catalog): | |||
| rname = "qq" | |||
| ch = ch1.merge(ch2, "emp.person.name", rname=rname) | |||
|
|
|||
| assert list(ch.signals_schema.values.keys()) == ["emp", rname + "emp"] | |||
| assert list(ch.signals_schema.values.keys()) == ["sys", "emp", rname + "emp"] | |||
There was a problem hiding this comment.
Are we exposing sys to user? We shouldn't .
There was a problem hiding this comment.
signals_schema always include sys signals, and signals_schema is not public.
So, no, it's not exposed to users.
| @@ -116,7 +116,13 @@ def test_merge_values(catalog): | |||
|
|
|||
| ch = ch1.merge(ch2, "id") | |||
|
|
|||
| assert list(ch.signals_schema.values.keys()) == ["id", "descr", "right_id", "time"] | |||
| assert list(ch.signals_schema.values.keys()) == [ | |||
| "sys", | |||
There was a problem hiding this comment.
The same. User should never see sys id (when it was not requested).
rlamy
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114.
For now, I am going to ignore
syssignals even ifsettings(sys=True)is passed.