Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #17

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Update README.rst #17

merged 2 commits into from
Jul 11, 2024

Conversation

volkfox
Copy link
Contributor

@volkfox volkfox commented Jul 11, 2024

fix CI error and incorporate other changes

volkfox added 2 commits July 11, 2024 14:23
fix CI error and incorporate other changes
@volkfox volkfox requested a review from dmpetrov July 11, 2024 21:32
Copy link
Member

@dmpetrov dmpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

There is a comment inline and we need to return back the CV Tutorial in Colab

except Exception as e:
print(f"do you have the right Mistral API key? {e}")
print(f"do you have the right Mistral API key? {e}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not handle any exceptions in the tutorials

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a good reason for this piece of code:

most errors in this example are related to a wrong API key

@volkfox volkfox merged commit 74e120e into main Jul 11, 2024
9 of 10 checks passed
@volkfox volkfox deleted the volkfox-patch-1 branch July 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants