-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutate can rename columns #312
Conversation
|
||
Example: | ||
```py | ||
dc.mutate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a new string here? seems that it's small enough to fit the same line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I get more clarity on the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's minor, not a blocker:
just to clarify - what I meant is to have
dc.mutate(newkey=Column("oldkey"))
(w/o extra newlines).
Again, not a blocker at all, just a suggestion to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @srini047 ! I left some comments in the ticket and in the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 90 90
Lines 9899 9899
Branches 1996 1996
=======================================
Hits 8606 8606
Misses 944 944
Partials 349 349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thanks @srini047 ! |
Fixes: #298
Docs: mutate() can rename columns with example