-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all column types in SignalSchema.from_column_types #319
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 86.94% 87.00% +0.05%
==========================================
Files 90 90
Lines 9898 9901 +3
Branches 1995 1997 +2
==========================================
+ Hits 8606 8614 +8
+ Misses 944 939 -5
Partials 348 348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a regression test somewhere?
c5bbb39
to
81634c2
Compare
Deploying datachain-documentation with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
81634c2
to
bb6ff4d
Compare
Wasn't sure about this approach. Updated the PR with better code, added test, please, take a look 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
d004430
to
5a9f335
Compare
Having registered dataset:
Making basic query on it:
Fails with error:
This is because
sys__rand
column type isUInt64
(at least in SaaS), and this type is not exists inDATACHAIN_TO_TYPE
, which leads to an error here: https://github.com/iterative/datachain/blob/main/src/datachain/lib/signal_schema.py#L107-L111