Fixing get_file_signals for custom types #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
get_file_signals
for proper custom type handling, removing the workaround previously added due to lack of custom type serialization / deserialization. This also adds a test to ensure these types are processed correctly, so that this can be caught earlier than Studio end-to-end tests.This has been tested with my local Studio install to work with both old (no custom types) datasets and new datasets (with custom types) with both custom type display and image preview working. This is a followup to #348 and is part of https://github.com/iterative/studio/issues/10417 and https://github.com/iterative/studio/issues/10547