Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing get_file_signals for custom types #371

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dtulga
Copy link
Contributor

@dtulga dtulga commented Aug 28, 2024

This fixes get_file_signals for proper custom type handling, removing the workaround previously added due to lack of custom type serialization / deserialization. This also adds a test to ensure these types are processed correctly, so that this can be caught earlier than Studio end-to-end tests.

This has been tested with my local Studio install to work with both old (no custom types) datasets and new datasets (with custom types) with both custom type display and image preview working. This is a followup to #348 and is part of https://github.com/iterative/studio/issues/10417 and https://github.com/iterative/studio/issues/10547

@dtulga dtulga self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (477d7d5) to head (d9e8ada).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   86.72%   86.71%   -0.01%     
==========================================
  Files          91       91              
  Lines       10092    10085       -7     
  Branches     2051     2049       -2     
==========================================
- Hits         8752     8745       -7     
  Misses        985      985              
  Partials      355      355              
Flag Coverage Δ
datachain 86.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtulga dtulga marked this pull request as ready for review August 28, 2024 18:21
@dtulga dtulga merged commit 13f6982 into main Aug 28, 2024
38 checks passed
@dtulga dtulga deleted the dtulga/fix-file-signals-custom-types branch August 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants