query: remove use of pipe for communication #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
requested review from
rlamy,
dreadatour,
dtulga,
ilongin and
amritghimire
skshetry
commented
Sep 4, 2024
src/datachain/catalog/catalog.py
Outdated
Comment on lines
1935
to
1937
| for dataset, dv, job in self.list_datasets_versions(): | ||
| if job and str(job.id) == job_id: | ||
| yield dv.created_at, (dataset, dv) |
There was a problem hiding this comment.
We might need an API for listing dataset versions by a given job id in the future for performance reasons.
ilongin
approved these changes
Sep 4, 2024
skshetry
force-pushed
the
remove-comm-channel
branch
from
38466d2 to
2e23af7
Compare
Deploying datachain-documentation with
|
| Latest commit: |
ed7f42b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00640549.datachain-documentation.pages.dev |
| Branch Preview URL: | https://remove-comm-channel.datachain-documentation.pages.dev |
skshetry
force-pushed
the
remove-comm-channel
branch
from
2e23af7 to
4f50d07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 86.81% 86.82% +0.01%
==========================================
Files 93 93
Lines 10079 10043 -36
Branches 2048 2045 -3
==========================================
- Hits 8750 8720 -30
+ Misses 984 980 -4
+ Partials 345 343 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
skshetry
force-pushed
the
remove-comm-channel
branch
from
4f50d07 to
c841cee
Compare
skshetry
force-pushed
the
remove-comm-channel
branch
from
c841cee to
8814ef6
Compare
skshetry
force-pushed
the
remove-comm-channel
branch
from
8814ef6 to
ed7f42b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, we fetch all dataset versions created with a given
job_id, and then choose the latest one by itsdatetime. (If there are multiple dataset versions with the same datetime, the first one encountered is used but that may be rare).This removes the need for using a pipe to read and write dataset version from a script, which is too complicated.
Part of #360.