-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not require last statement to be an expression or an instance of DatasetQuery #395
Conversation
@@ -971,42 +971,6 @@ def test_query_subprocess_wrong_return_code(mock_popen, cloud_test_catalog): | |||
assert str(exc_info.value).startswith("Query script exited with error code 1") | |||
|
|||
|
|||
def test_query_last_statement_not_expression(mock_popen, cloud_test_catalog): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are mocked tests. And since these tests are no longer a failure, they are not useful.
(There is a real test in test_query.py
below).
7098d80
to
5ccdef3
Compare
Deploying datachain-documentation with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 86.82% 86.72% -0.11%
==========================================
Files 93 93
Lines 10043 10040 -3
Branches 2045 2044 -1
==========================================
- Hits 8720 8707 -13
- Misses 980 987 +7
- Partials 343 346 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you! 🙏
We also need to make sure it all works on Studio side (including frontend part).
It does work well on Studio. We might need to adjust some stuff like "Register dataset" button which is no longer possible as we need explicit saves. But I'd not consider this as completely functional, that will happen when we completely remove this wrapping thing. |
Thank you for handling this ❤️ |
5ccdef3
to
638bafe
Compare
This PR removes the requirement for the last statement to be either an expression or an instance of DatasetQuery.
After this PR, scripts without a final expression will function properly in both Datachain and Studio.
The last statement wrappers and related infrastructure will be removed in subsequent PRs.
However, this PR demonstrates that everything already works and is usable.
Part of #360.