Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the DataChain logo in the README and docs #402

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

djsauble
Copy link
Contributor

@djsauble djsauble commented Sep 6, 2024

Supersedes #401

Before

README

image

Docs

image

After

README

image

Docs

image

@djsauble djsauble marked this pull request as draft September 6, 2024 20:20
Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: d51bdec
Status: ✅  Deploy successful!
Preview URL: https://27555d59.datachain-documentation.pages.dev
Branch Preview URL: https://update-datachain-logo-in-doc.datachain-documentation.pages.dev

View logs

@djsauble djsauble changed the title Update the DataChain logo Update the DataChain logo in the README and docs Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (f19095b) to head (d51bdec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files          93       93           
  Lines       10029    10029           
  Branches     2046     2044    -2     
=======================================
  Hits         8752     8752           
  Misses        919      919           
  Partials      358      358           
Flag Coverage Δ
datachain 87.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsauble djsauble self-assigned this Sep 6, 2024
@djsauble djsauble marked this pull request as ready for review September 6, 2024 20:43
@djsauble djsauble mentioned this pull request Sep 6, 2024
Copy link

@jendefig jendefig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'll just close mine.

@djsauble djsauble merged commit a0ce094 into main Sep 6, 2024
32 of 38 checks passed
@djsauble djsauble deleted the update_datachain_logo_in_docs_and_readme branch September 6, 2024 21:15
@@ -1,3 +1,7 @@
.. image:: docs/assets/datachain_logotype.svg
Copy link
Member

@skshetry skshetry Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project name is hidden on light mode.

Screenshot 2024-09-07 at 07 26 32

Copy link
Contributor

@yathomasi yathomasi Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants