Make datachain logo show up properly on Safari in dark mode #413
Conversation
for more information, see https://pre-commit.ci
Deploying datachain-documentation with
|
| Latest commit: |
00c1741
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f2ca32d.datachain-documentation.pages.dev |
| Branch Preview URL: | https://fix-dark-mode-on-safari.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 87.31% 87.31%
=======================================
Files 92 92
Lines 9982 9982
Branches 2041 2041
=======================================
Hits 8716 8716
Misses 911 911
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
| :height: 48 | ||
| :alt: DataChain logo | ||
|
|
||
| ================ |
There was a problem hiding this comment.
top line looks dodgy on light mode
There was a problem hiding this comment.
Not enough contrast?
There was a problem hiding this comment.
This is a bit of a hack, but I can just give the logo a black background so it shows up clearly regardless of theme.
There was a problem hiding this comment.
I think it was fine before, I would just remove the extra top line
There was a problem hiding this comment.
That might just be a GitHub bug, I see it in other repos too.
There was a problem hiding this comment.
I removed that top line and still see that artifact. 🤷
This reverts commit d2dfd01.
Dark mode:
Light mode:
