unskip test_udf_parallel #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
2f43636
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c595b45e.datachain-documentation.pages.dev |
| Branch Preview URL: | https://unskip-test.datachain-documentation.pages.dev |
mattseddon
commented
Sep 12, 2024
| vals = ["a", "b", "c", "d", "e", "f"] | ||
| chain = DataChain.from_values(key=vals) | ||
|
|
||
| class MyMapper(Mapper): |
There was a problem hiding this comment.
[F] Moving this into the local scope makes it possible for the test to pass.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 92 92
Lines 9977 9977
Branches 2053 2053
=======================================
Hits 8701 8701
Misses 922 922
Partials 354 354
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattseddon
commented
Sep 12, 2024
mattseddon
force-pushed
the
unskip-test
branch
from
21f749a to
2f43636
Compare
ilongin
approved these changes
Sep 12, 2024
amritghimire
approved these changes
Sep 12, 2024
rlamy
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unskips the test skipped here