fix last modified comparison in resolve file test #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
1db7334
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://848133ac.datachain-documentation.pages.dev |
| Branch Preview URL: | https://fix-resolve-file-test.datachain-documentation.pages.dev |
shcheklein
approved these changes
Sep 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 92 92
Lines 9954 9954
Branches 2048 2048
=======================================
Hits 8687 8687
Misses 913 913
Partials 354 354
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattseddon
force-pushed
the
fix-resolve-file-test
branch
from
232cc49 to
1db7334
Compare
mattseddon
changed the title
mattseddon
commented
Sep 12, 2024
| @@ -327,11 +329,21 @@ def test_read_text(tmp_path, catalog): | |||
| def test_resolve_file(cloud_test_catalog): | |||
| ctc = cloud_test_catalog | |||
|
|
|||
| is_sqlite = isinstance(cloud_test_catalog.catalog.warehouse, SQLiteWarehouse) | |||
There was a problem hiding this comment.
there is a similar strategy in test_from_storage_check_rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.