chore(hf): remove unused arguments #556
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 87.87% 87.87%
=======================================
Files 96 96
Lines 9873 9873
Branches 1349 1349
=======================================
Hits 8676 8676
Misses 857 857
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying datachain-documentation with
|
| Latest commit: |
ab29af7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd714b5a.datachain-documentation.pages.dev |
| Branch Preview URL: | https://minor-cleanup-hf-get-output.datachain-documentation.pages.dev |
|
|
||
|
|
||
| def _feature_to_chain_type(name: str, val: Any) -> type: # noqa: PLR0911 | ||
| def _feature_to_chain_type(name: str, val: Any) -> DataType: # noqa: PLR0911 | ||
| if isinstance(val, Value): | ||
| return arrow_type_mapper(val.pa_type) |
There was a problem hiding this comment.
I see arrow_type_mapper also returns type but seems like it should also return DataType, right? Maybe worth including in the PR. I think this stems from arrow_type_mapper predating DataType.
There was a problem hiding this comment.
yes, more cleanup / review is needed there with types
e.g. we return list(list ... and it's not really DataType AFAIU
it's not a complete solution, thus we still have a lot of ignore type pragmas
* chore(hf): remove unused arguments * cleanup types a bit in hf
Minor cleanup in HF integration code.