Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File() and UDF refactoring #56

Merged
merged 10 commits into from
Jul 16, 2024
Merged

File() and UDF refactoring #56

merged 10 commits into from
Jul 16, 2024

Conversation

rlamy
Copy link
Contributor

@rlamy rlamy commented Jul 15, 2024

Fixes #34 and #35

@rlamy rlamy marked this pull request as draft July 15, 2024 22:04
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 90.09009% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (6c0fdba) to head (d821b45).

Files Patch % Lines
src/datachain/lib/udf.py 88.00% 2 Missing and 4 partials ⚠️
src/datachain/lib/file.py 86.36% 2 Missing and 1 partial ⚠️
src/datachain/query/udf.py 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   84.03%   84.00%   -0.04%     
==========================================
  Files          91       90       -1     
  Lines        9406     9413       +7     
  Branches     1849     1858       +9     
==========================================
+ Hits         7904     7907       +3     
- Misses       1178     1179       +1     
- Partials      324      327       +3     
Flag Coverage Δ
datachain 83.93% <90.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmpetrov dmpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at the lib level. However, I'm not bit an expert in the query/udf.
PLease feel free to merge when it's ready.

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: d821b45
Status: ✅  Deploy successful!
Preview URL: https://6ef797c8.datachain-documentation.pages.dev
Branch Preview URL: https://udf-refactor.datachain-documentation.pages.dev

View logs

@rlamy rlamy marked this pull request as ready for review July 16, 2024 15:12
@rlamy rlamy requested review from dreadatour, dtulga and skshetry July 16, 2024 15:13
Copy link
Contributor

@dreadatour dreadatour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! 👍
Approving it because it looks solid and I suppose it has been tested well.
I wish I have much more time to dive into all the details and test all the changes.

@rlamy rlamy merged commit 552c5d6 into main Jul 16, 2024
19 checks passed
@rlamy rlamy deleted the udf-refactor branch July 16, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar for downloads using File()
3 participants