-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File() and UDF refactoring #56
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 84.03% 84.00% -0.04%
==========================================
Files 91 90 -1
Lines 9406 9413 +7
Branches 1849 1858 +9
==========================================
+ Hits 7904 7907 +3
- Misses 1178 1179 +1
- Partials 324 327 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at the lib level. However, I'm not bit an expert in the query/udf.
PLease feel free to merge when it's ready.
Deploying datachain-documentation with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me! 👍
Approving it because it looks solid and I suppose it has been tested well.
I wish I have much more time to dive into all the details and test all the changes.
Also, add functional tests for cache use in DataChain.
Fixes #34 and #35