Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UInt32 #568

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Support for UInt32 #568

merged 1 commit into from
Nov 6, 2024

Conversation

ilongin
Copy link
Contributor

@ilongin ilongin commented Nov 6, 2024

Added support for UInt32 type

@ilongin ilongin linked an issue Nov 6, 2024 that may be closed by this pull request
@ilongin ilongin mentioned this pull request Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (4f87dc8) to head (2166169).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/sql/types.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files          96       96           
  Lines        9888     9907   +19     
  Branches     1350     1350           
=======================================
+ Hits         8691     8708   +17     
- Misses        857      859    +2     
  Partials      340      340           
Flag Coverage Δ
datachain 87.83% <89.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilongin ilongin requested review from a team, dreadatour, shcheklein, amritghimire, skshetry and mattseddon and removed request for a team November 6, 2024 09:44
@ilongin ilongin merged commit 4f08133 into main Nov 6, 2024
38 checks passed
@ilongin ilongin deleted the ilongin/567-uint32 branch November 6, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for UInt32
2 participants