Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing torch dependencies test #59

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 16, 2024

Closes #52. This PR adds a test which confirms that the optional [torch] dependencies are not needed to import datachain (and that they are required in order to import datachain.torch)

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: b72c306
Status: ✅  Deploy successful!
Preview URL: https://63a747c7.datachain-documentation.pages.dev
Branch Preview URL: https://add-missing-cv-tests.datachain-documentation.pages.dev

View logs

@mattseddon mattseddon self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (9ca80fb) to head (b72c306).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   83.62%   83.64%   +0.02%     
==========================================
  Files          93       93              
  Lines        9424     9424              
  Branches     1868     1868              
==========================================
+ Hits         7881     7883       +2     
+ Misses       1215     1213       -2     
  Partials      328      328              
Flag Coverage Δ
datachain 83.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon force-pushed the add-missing-cv-tests branch from d29310c to b72c306 Compare July 16, 2024 21:20
@mattseddon mattseddon changed the title add missing cv dependencies test add missing torch dependencies test Jul 16, 2024
@mattseddon mattseddon marked this pull request as ready for review July 16, 2024 21:48
@mattseddon mattseddon requested review from dberenbaum and a team July 16, 2024 21:48
Copy link
Contributor

@dtulga dtulga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mattseddon mattseddon merged commit d39d9af into main Jul 16, 2024
19 checks passed
@mattseddon mattseddon deleted the add-missing-cv-tests branch July 16, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional [cv] dependency appears mandatory
3 participants